r54335 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54334‎ | r54335 | r54336 >
Date:00:28, 4 August 2009
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Show change flag tooltips everywhere, not just RC

Follow-up to r54242. Pointed out by Umherirrender on CodeReview.
Modified paths:
  • /trunk/phase3/includes/PageHistory.php (modified) (history)
  • /trunk/phase3/includes/diff/DifferenceEngine.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialDeletedContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceEngine.php
@@ -304,10 +304,10 @@
305305 $newminor = '';
306306
307307 if( $this->mOldRev->isMinor() ) {
308 - $oldminor = Xml::element( 'abbr', array( 'class' => 'minor' ), wfMsg( 'minoreditletter') ) . ' ';
 308+ $oldminor = ChangesList::flag( 'minor' );
309309 }
310310 if( $this->mNewRev->isMinor() ) {
311 - $newminor = Xml::element( 'abbr', array( 'class' => 'minor' ), wfMsg( 'minoreditletter') ) . ' ';
 311+ $newminor = ChangesList::flag( 'minor' );
312312 }
313313
314314 $rdel = ''; $ldel = '';
Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -384,7 +384,7 @@
385385
386386 function __construct( $target, $namespace = false, $year = false, $month = false, $tagFilter = false ) {
387387 parent::__construct();
388 - foreach( explode( ' ', 'uctop diff newarticle rollbacklink diff hist newpageletter minoreditletter' ) as $msg ) {
 388+ foreach( explode( ' ', 'uctop diff newarticle rollbacklink diff hist' ) as $msg ) {
389389 $this->messages[$msg] = wfMsgExt( $msg, array( 'escape') );
390390 }
391391 $this->target = $target;
@@ -565,13 +565,13 @@
566566 }
567567
568568 if( $rev->getParentId() === 0 ) {
569 - $nflag = '<abbr class="newpage">' . $this->messages['newpageletter'] . '</abbr>';
 569+ $nflag = ChangesList::flag( 'newpage' );
570570 } else {
571571 $nflag = '';
572572 }
573573
574574 if( $rev->isMinor() ) {
575 - $mflag = '<abbr class="minor">' . $this->messages['minoreditletter'] . '</abbr> ';
 575+ $mflag = ChangesList::flag( 'minor' );
576576 } else {
577577 $mflag = '';
578578 }
Index: trunk/phase3/includes/specials/SpecialDeletedContributions.php
@@ -11,7 +11,7 @@
1212
1313 function __construct( $target, $namespace = false ) {
1414 parent::__construct();
15 - foreach( explode( ' ', 'deletionlog undeleteviewlink minoreditletter diff' ) as $msg ) {
 15+ foreach( explode( ' ', 'deletionlog undeleteviewlink diff' ) as $msg ) {
1616 $this->messages[$msg] = wfMsgExt( $msg, array( 'escape') );
1717 }
1818 $this->target = $target;
@@ -184,7 +184,7 @@
185185 $pagelink = $sk->link( $page );
186186
187187 if( $rev->isMinor() ) {
188 - $mflag = '<abbr class="minor">' . $this->messages['minoreditletter'] . '</abbr> ';
 188+ $mflag = ChangesList::flag( 'minor' );
189189 } else {
190190 $mflag = '';
191191 }
@@ -426,4 +426,4 @@
427427 Xml::closeElement( 'form' );
428428 return $f;
429429 }
430 -}
\ No newline at end of file
 430+}
Index: trunk/phase3/includes/PageHistory.php
@@ -321,7 +321,7 @@
322322 $s .= " <span class='history-user'>" . $this->mSkin->revUserTools( $rev, true ) . "</span>";
323323
324324 if( $rev->isMinor() ) {
325 - $s .= ' ' . Xml::element( 'abbr', array( 'class' => 'minor' ), wfMsg( 'minoreditletter') );
 325+ $s .= ' ' . ChangesList::flag( 'minor' );
326326 }
327327
328328 if( !is_null( $size = $rev->getSize() ) && !$rev->isDeleted( Revision::DELETED_TEXT ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54242Add legend and tooltips to explain RC flags...simetrical22:15, 2 August 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   22:27, 4 August 2009

adding fixme for funky-looking legend, possibly pending removal

#Comment by Werdna (talk | contribs)   17:02, 27 August 2009

Not related to the legend, and it's okay anyway.

Status & tagging log