r54324 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54323‎ | r54324 | r54325 >
Date:23:08, 3 August 2009
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Refactoring for 0.3
Modified paths:
  • /trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMaps.php (modified) (history)
  • /trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/OpenLayers/SM_OpenLayers.php (modified) (history)
  • /trunk/extensions/SemanticMaps/OpenLayers/SM_OpenLayersFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/SM_MapPrinter.php (modified) (history)
  • /trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMaps.php (modified) (history)
  • /trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMapsFormInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMaps.php
@@ -26,9 +26,9 @@
2727 *
2828 */
2929 protected function setQueryPrinterSettings() {
30 - global $egMapsGoogleMapsZoom;
 30+ global $egMapsGoogleMapsZoom, $egMapsGoogleMapsPrefix;
3131
32 - $this->elementNamePrefix = 'map_google';
 32+ $this->elementNamePrefix = $egMapsGoogleMapsPrefix;
3333
3434 $this->defaultZoom = $egMapsGoogleMapsZoom;
3535 }
Index: trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsFormInput.php
@@ -22,9 +22,9 @@
2323 *
2424 */
2525 protected function setMapSettings() {
26 - global $egMapsGoogleMapsZoom;
 26+ global $egMapsGoogleMapsZoom, $egMapsGoogleMapsPrefix;
2727
28 - $this->elementNamePrefix = 'map_google';
 28+ $this->elementNamePrefix = $egMapsGoogleMapsPrefix;
2929 $this->showAddresFunction = 'showGAddress';
3030
3131 $this->earthZoom = 1;
Index: trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMaps.php
@@ -24,9 +24,9 @@
2525 *
2626 */
2727 protected function setQueryPrinterSettings() {
28 - global $egMapsYahooMapsZoom;
 28+ global $egMapsYahooMapsZoom, $egMapsYahooMapsPrefix;
2929
30 - $this->elementNamePrefix = 'map_yahoo';
 30+ $this->elementNamePrefix = $egMapsYahooMapsPrefix;
3131 $this->defaultZoom = $egMapsYahooMapsZoom;
3232 }
3333
Index: trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMapsFormInput.php
@@ -20,9 +20,9 @@
2121 *
2222 */
2323 protected function setMapSettings() {
24 - global $egMapsYahooMapsZoom;
 24+ global $egMapsYahooMapsZoom, $egMapsYahooMapsPrefix;
2525
26 - $this->elementNamePrefix = 'map_yahoo';
 26+ $this->elementNamePrefix = $egMapsYahooMapsPrefix;
2727 $this->showAddresFunction = 'showYAddress';
2828
2929 $this->earthZoom = 17;
Index: trunk/extensions/SemanticMaps/OpenLayers/SM_OpenLayers.php
@@ -25,9 +25,9 @@
2626 *
2727 */
2828 protected function setQueryPrinterSettings() {
29 - global $egMapsOpenLayersZoom;
 29+ global $egMapsOpenLayersZoom, $egMapsOpenLayersPrefix;
3030
31 - $this->elementNamePrefix = 'open_layer';
 31+ $this->elementNamePrefix = $egMapsOpenLayersPrefix;
3232 $this->defaultZoom = $egMapsOpenLayersZoom;
3333 }
3434
Index: trunk/extensions/SemanticMaps/OpenLayers/SM_OpenLayersFormInput.php
@@ -20,9 +20,9 @@
2121 *
2222 */
2323 protected function setMapSettings() {
24 - global $egMapsOpenLayersZoom;
 24+ global $egMapsOpenLayersZoom, $egMapsOpenLayersPrefix;
2525
26 - $this->elementNamePrefix = 'open_layer';
 26+ $this->elementNamePrefix = $egMapsOpenLayersPrefix;
2727 $this->showAddresFunction = 'showOLAddress';
2828
2929 $this->earthZoom = 1;
Index: trunk/extensions/SemanticMaps/SM_MapPrinter.php
@@ -45,9 +45,14 @@
4646
4747 protected $output = '';
4848
 49+ protected $mapFeature;
 50+
4951 /**
50 - *
 52+ * Builds up and returns the HTML for the map, with the queried coordinate data on it.
5153 *
 54+ * @param unknown_type $res
 55+ * @param unknown_type $outputmode
 56+ * @return unknown
5257 */
5358 public final function getResultText($res, $outputmode) {
5459 $this->formatResultData($res, $outputmode);

Status & tagging log