r54323 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54322‎ | r54323 | r54324 >
Date:23:07, 3 August 2009
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Refactoring for 0.3
Modified paths:
  • /trunk/extensions/Maps/GoogleMaps/Maps_GoogleMaps.php (modified) (history)
  • /trunk/extensions/Maps/Maps_Settings.php (modified) (history)
  • /trunk/extensions/Maps/OpenLayers/Maps_OpenLayers.php (modified) (history)
  • /trunk/extensions/Maps/YahooMaps/Maps_YahooMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/OpenLayers/Maps_OpenLayers.php
@@ -108,9 +108,9 @@
109109 *
110110 */
111111 protected function setMapSettings() {
112 - global $egMapsOpenLayersZoom;
 112+ global $egMapsOpenLayersZoom, $egMapsOpenLayersPrefix;
113113
114 - $this->elementNamePrefix = 'open_layer';
 114+ $this->elementNamePrefix = $egMapsOpenLayersPrefix;
115115 $this->defaultZoom = $egMapsOpenLayersZoom;
116116 }
117117
Index: trunk/extensions/Maps/GoogleMaps/Maps_GoogleMaps.php
@@ -96,9 +96,9 @@
9797 *
9898 */
9999 protected function setMapSettings() {
100 - global $egMapsGoogleMapsZoom;
 100+ global $egMapsGoogleMapsZoom, $egMapsGoogleMapsPrefix;
101101
102 - $this->elementNamePrefix = 'map_google';
 102+ $this->elementNamePrefix = $egMapsGoogleMapsPrefix;
103103 $this->defaultZoom = $egMapsGoogleMapsZoom;
104104 }
105105
Index: trunk/extensions/Maps/YahooMaps/Maps_YahooMaps.php
@@ -64,9 +64,9 @@
6565 *
6666 */
6767 protected function setMapSettings() {
68 - global $egMapsYahooMapsZoom;
 68+ global $egMapsYahooMapsZoom, $egMapsYahooMapsPrefix;
6969
70 - $this->elementNamePrefix = 'map_yahoo';
 70+ $this->elementNamePrefix = $egMapsYahooMapsPrefix;
7171 $this->defaultZoom = $egMapsYahooMapsZoom;
7272 }
7373
Index: trunk/extensions/Maps/Maps_Settings.php
@@ -97,4 +97,9 @@
9898 # Available values: google, bing, yahoo, openlayers, nasa
9999 $egMapsOLLayers = array('openlayers');
100100
 101+# String(s). The map name prefixes for each service. They can not be identical.
 102+$egMapsGoogleMapsPrefix = 'map_google';
 103+$egMapsYahooMapsPrefix = 'map_yahoo';
 104+$egMapsOpenLayersPrefix = 'open_layer';
101105
 106+

Status & tagging log