r54244 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54243‎ | r54244 | r54245 >
Date:22:55, 2 August 2009
Author:demon
Status:resolved (Comments)
Tags:
Comment:
(bug 18855) Consistently call commandLine.inc with how we more or less do it now.
Modified paths:
  • /trunk/phase3/maintenance/language/date-formats.php (modified) (history)
  • /trunk/phase3/maintenance/language/digit2html.php (modified) (history)
  • /trunk/phase3/maintenance/preprocessorFuzzTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/digit2html.php
@@ -4,7 +4,7 @@
55 * @ingroup MaintenanceLanguage
66 */
77
8 -require( '../commandLine.inc' );
 8+require_once( dirname(__FILE__).'/../commandLine.inc' );
99
1010 # A list of unicode numerals is available at:
1111 # http://www.fileformat.info/info/unicode/category/Nd/list.htm
Index: trunk/phase3/maintenance/language/date-formats.php
@@ -8,7 +8,7 @@
99
1010
1111 $IP = dirname( __FILE__ ) . '/../..';
12 -require_once( "$IP/maintenance/commandLine.inc" );
 12+require_once( dirname(__FILE__).'/../commandLine.inc' );
1313
1414 foreach ( glob( "$IP/languages/messages/Messages*.php" ) as $filename ) {
1515 $base = basename( $filename );
Index: trunk/phase3/maintenance/preprocessorFuzzTest.php
@@ -4,7 +4,7 @@
55 * @ingroup Maintenance
66 */
77
8 -require_once( dirname( __FILE__ ). '/../maintenance/commandLine.inc' );
 8+require_once( 'commandLine.inc' );
99
1010 $wgHooks['BeforeParserFetchTemplateAndtitle'][] = 'PPFuzzTester::templateHook';
1111

Follow-up revisions

RevisionCommit summaryAuthorDate
r54312Revert r54244 which was stupid and fix this properly. Require commandLine.inc...demon21:56, 3 August 2009

Comments

#Comment by Nikerabbit (talk | contribs)   08:54, 3 August 2009

Isn't that more inconsistent now? Scripts in the main directory allow (for good and bad) providing alternative commandLine.inc by putting it somewhere in the path with higher precedence, while all other scripts use the one and only.

Status & tagging log