r54214 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54213‎ | r54214 | r54215 >
Date:15:22, 2 August 2009
Author:churchofemacs
Status:ok (Comments)
Tags:
Comment:
fixing bug 17395
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/filerepo/File.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/File.php
@@ -1064,15 +1064,15 @@
10651065 * Get the HTML text of the description page, if available
10661066 */
10671067 function getDescriptionText() {
1068 - global $wgMemc, $wgContLang;
 1068+ global $wgMemc, $wgLang;
10691069 if ( !$this->repo->fetchDescription ) {
10701070 return false;
10711071 }
1072 - $renderUrl = $this->repo->getDescriptionRenderUrl( $this->getName(), $wgContLang->getCode() );
 1072+ $renderUrl = $this->repo->getDescriptionRenderUrl( $this->getName(), $wgLang->getCode() );
10731073 if ( $renderUrl ) {
10741074 if ( $this->repo->descriptionCacheExpiry > 0 ) {
10751075 wfDebug("Attempting to get the description from cache...");
1076 - $key = $this->repo->getLocalCacheKey( 'RemoteFileDescription', 'url', $wgContLang->getCode(),
 1076+ $key = $this->repo->getLocalCacheKey( 'RemoteFileDescription', 'url', $wgLang->getCode(),
10771077 $this->getName() );
10781078 $obj = $wgMemc->get($key);
10791079 if ($obj) {
Index: trunk/phase3/RELEASE-NOTES
@@ -363,7 +363,10 @@
364364 "editusercssjs" into "editusercss" and edituserjs" respectively.
365365 * (bug 19394) RecentChanges feed URLs for log items with no revisions
366366 (eg Newuser, Userrights) are no longer broken
 367+* (bug 17395) Remote file descriptions use user language ($wgLang), not wiki
 368+ language ($wgContLang)
367369
 370+
368371 == API changes in 1.16 ==
369372
370373 * Added uiprop=changeablegroups to meta=userinfo

Comments

#Comment by RobertL (talk | contribs)   21:12, 2 August 2009

Please can you describe what your commit is actually doing in commit messages, rather than simply referencing bug numbers.

#Comment by Church of emacs (talk | contribs)   22:03, 2 August 2009

I'm really sorry, from now on I'll do that. My change corrects the language used in remote file descriptions.

Status & tagging log