r54180 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r54179‎ \| r54180 \| r54181 >
Date:	18:44, 1 August 2009
Author:	demon
Status:	ok
Tags:
Comment:	Http::get() doesn't return an object, it already returns the results or null anyway. BTW: is anyone actually still using this? stab
Modified paths:	/trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
—	—	@@ -2722,10 +2722,7 @@
2723	2723	*/
2724	2724	function wfGetHTTP( $url ) {
2725	2725	wfDeprecated(__FUNCTION__);
2726		~~- $status = Http::get( $url );~~
2727		~~- if( $status->isOK() )~~
2728		~~- return $status->value;~~
2729		~~- return null;~~
	2726	+ return Http::get( $url );
2730	2727	}
2731	2728
2732	2729	/**

23:28, 19 August 2009 Brion VIBBER (talk | contribs) changed the status of r54180 [removed: new added: ok]