r53975 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53974‎ | r53975 | r53976 >
Date:22:15, 29 July 2009
Author:demon
Status:ok
Tags:
Comment:
* (bug 16311) Make recent change flags acronyms instead of spans. Also move this crap to common, we don't need identical declarations in 5 different skins.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ChangesList.php (modified) (history)
  • /trunk/phase3/includes/PageHistory.php (modified) (history)
  • /trunk/phase3/includes/diff/DifferenceEngine.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialDeletedContributions.php (modified) (history)
  • /trunk/phase3/skins/chick/main.css (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/main.css
@@ -376,9 +376,6 @@
377377 font-size: 75%;
378378 text-align: right;
379379 }
380 -span.newpage, span.minor {
381 - font-weight: bold;
382 -}
383380
384381 span.updatedmarker {
385382 color:black;
Index: trunk/phase3/skins/monobook/main.css
@@ -1125,9 +1125,6 @@
11261126 div.patrollink {
11271127 clear: both;
11281128 }
1129 -span.newpage, span.minor, span.bot {
1130 - font-weight: bold;
1131 -}
11321129
11331130 .sharedUploadNotice {
11341131 font-style: italic;
Index: trunk/phase3/skins/modern/main.css
@@ -633,11 +633,6 @@
634634 display: none;
635635 }
636636
637 -
638 -span.newpage, span.minor, span.bot {
639 - font-weight: bold;
640 -}
641 -
642637 .sharedUploadNotice {
643638 font-style: italic;
644639 }
Index: trunk/phase3/skins/common/shared.css
@@ -435,6 +435,11 @@
436436 border: 1px dashed #aaa;
437437 }
438438
 439+/** Generic minor/bot/newpage styling */
 440+abbr.newpage, abbr.minor, abbr.bot {
 441+ font-weight: bold;
 442+}
 443+
439444 /* Special:Contributions styling */
440445 .mw-uctop {
441446 font-weight: bold;
Index: trunk/phase3/skins/vector/main-ltr.css
@@ -980,10 +980,7 @@
981981 padding-left: 15px !important;
982982 text-transform: none;
983983 }
984 -/* To be sorted */
985 -span.newpage, span.minor, span.bot {
986 - font-weight: bold;
987 -}
 984+
988985 .toccolours {
989986 border: 1px solid #aaa;
990987 background-color: #f9f9f9;
Index: trunk/phase3/skins/vector/main-rtl.css
@@ -980,10 +980,7 @@
981981 padding-right: 15px !important;
982982 text-transform: none;
983983 }
984 -/* To be sorted */
985 -span.newpage, span.minor, span.bot {
986 - font-weight: bold;
987 -}
 984+
988985 .toccolours {
989986 border: 1px solid #aaa;
990987 background-color: #f9f9f9;
Index: trunk/phase3/includes/diff/DifferenceEngine.php
@@ -304,10 +304,10 @@
305305 $newminor = '';
306306
307307 if( $this->mOldRev->isMinor() ) {
308 - $oldminor = Xml::span( wfMsg( 'minoreditletter' ), 'minor' ) . ' ';
 308+ $oldminor = Xml::element( 'abbr', array( 'class' => 'minor' ), wfMsg( 'minoreditletter') ) . ' ';
309309 }
310310 if( $this->mNewRev->isMinor() ) {
311 - $newminor = Xml::span( wfMsg( 'minoreditletter' ), 'minor' ) . ' ';
 311+ $newminor = Xml::element( 'abbr', array( 'class' => 'minor' ), wfMsg( 'minoreditletter') ) . ' ';
312312 }
313313
314314 $rdel = ''; $ldel = '';
Index: trunk/phase3/includes/ChangesList.php
@@ -87,10 +87,10 @@
8888 */
8989 protected function recentChangesFlags( $new, $minor, $patrolled, $nothing = ' ', $bot = false ) {
9090 $f = $new ?
91 - '<span class="newpage">' . $this->message['newpageletter'] . '</span>' : $nothing;
 91+ '<abbr class="newpage">' . $this->message['newpageletter'] . '</abbr>' : $nothing;
9292 $f .= $minor ?
93 - '<span class="minor">' . $this->message['minoreditletter'] . '</span>' : $nothing;
94 - $f .= $bot ? '<span class="bot">' . $this->message['boteditletter'] . '</span>' : $nothing;
 93+ '<abbr class="minor">' . $this->message['minoreditletter'] . '</abbr>' : $nothing;
 94+ $f .= $bot ? '<abbr class="bot">' . $this->message['boteditletter'] . '</abbr>' : $nothing;
9595 $f .= $patrolled ? '<span class="unpatrolled">!</span>' : $nothing;
9696 return $f;
9797 }
Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -562,13 +562,13 @@
563563 }
564564
565565 if( $rev->getParentId() === 0 ) {
566 - $nflag = '<span class="newpage">' . $this->messages['newpageletter'] . '</span>';
 566+ $nflag = '<abbr class="newpage">' . $this->messages['newpageletter'] . '</abbr>';
567567 } else {
568568 $nflag = '';
569569 }
570570
571571 if( $rev->isMinor() ) {
572 - $mflag = '<span class="minor">' . $this->messages['minoreditletter'] . '</span> ';
 572+ $mflag = '<abbr class="minor">' . $this->messages['minoreditletter'] . '</abbr> ';
573573 } else {
574574 $mflag = '';
575575 }
Index: trunk/phase3/includes/specials/SpecialDeletedContributions.php
@@ -183,7 +183,7 @@
184184 $pagelink = $sk->link( $page );
185185
186186 if( $rev->isMinor() ) {
187 - $mflag = '<span class="minor">' . $this->messages['minoreditletter'] . '</span> ';
 187+ $mflag = '<abbr class="minor">' . $this->messages['minoreditletter'] . '</abbr> ';
188188 } else {
189189 $mflag = '';
190190 }
Index: trunk/phase3/includes/PageHistory.php
@@ -321,7 +321,7 @@
322322 $s .= " <span class='history-user'>" . $this->mSkin->revUserTools( $rev, true ) . "</span>";
323323
324324 if( $rev->isMinor() ) {
325 - $s .= ' ' . Xml::element( 'span', array( 'class' => 'minor' ), wfMsg( 'minoreditletter') );
 325+ $s .= ' ' . Xml::element( 'abbr', array( 'class' => 'minor' ), wfMsg( 'minoreditletter') );
326326 }
327327
328328 if( !is_null( $size = $rev->getSize() ) && !$rev->isDeleted( Revision::DELETED_TEXT ) ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -348,6 +348,7 @@
349349 longer sent
350350 * (bug 19957) All known-failing tests now marked disabled; added --run-disabled
351351 option to parser test suite to run disabled tests if desired.
 352+* (bug 16311) Make recent change flags (n/m/b) <abbr>s instead of <span>s
352353
353354 == API changes in 1.16 ==
354355

Follow-up revisions

RevisionCommit summaryAuthorDate
r54241Allow <abbr> in wikitext...simetrical22:15, 2 August 2009
r54861Un-merge r53975, which was only partially merged in and broke stuff as a cons...catrope14:30, 12 August 2009

Status & tagging log