r53930 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53929‎ | r53930 | r53931 >
Date:12:23, 29 July 2009
Author:alexsh
Status:reverted (Comments)
Tags:
Comment:
forget to set table name to variable
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryBrokenRedirects.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryBrokenRedirects.php
@@ -62,7 +62,7 @@
6363 "rd_namespace",
6464 "rd_title",
6565 ));
66 - $this->addTables("redirect AS rd JOIN page p1 ON (rd.rd_from=p1.page_id) LEFT JOIN page AS p2 ON (rd_namespace=p2.page_namespace AND rd_title=p2.page_title )");
 66+ $this->addTables("$redirect AS rd JOIN $page p1 ON (rd.rd_from=p1.page_id) LEFT JOIN $page AS p2 ON (rd_namespace=p2.page_namespace AND rd_title=p2.page_title )");
6767 # I don't know why these two not work ~~Alexsh
6868 #$this->addJoinConds(array("$page AS p1" => array('JOIN', 'rd.rd_from=p1.page_id')));
6969 #$this->addJoinConds(array("$page AS p2" => array('LEFT JOIN', 'rd_namespace=p2.page_namespace AND rd_title=p2.page_title')));

Follow-up revisions

RevisionCommit summaryAuthorDate
r54265Revert r53678, r53704, r53705, r53773, r53930, r54199, r54201: Addition of Ap...btongminh11:06, 3 August 2009

Comments

#Comment by Bryan (talk | contribs)   11:08, 3 August 2009

Reverted in r54265.

Status & tagging log