r53759 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53758‎ | r53759 | r53760 >
Date:19:49, 25 July 2009
Author:catrope
Status:deferred
Tags:
Comment:
OptIn: Swap feedback and try links and tweak a few messages, both on Parul's request
Modified paths:
  • /trunk/extensions/UsabilityInitiative/OptIn/OptIn.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/OptIn/OptIn.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/OptIn/OptIn.hooks.php
@@ -51,17 +51,7 @@
5252 }
5353 $link = SpecialPage::getTitleFor( 'OptIn' )->getFullURL( $query );
5454
55 - // Inserts a link into personal tools
56 - $addLinks = array(
57 - 'acaibeta' => array(
58 - 'text' => SpecialOptIn::isOptedIn( $wgUser ) ?
59 - wfMsg( 'optin-leave' ) :
60 - wfMsg( 'optin-try' ),
61 - 'href' => $link,
62 - 'class' => 'no-text-transform'
63 - )
64 - );
65 -
 55+ $addLinks = array();
6656 // For opted-in users, add a feedback link
6757 if ( SpecialOptIn::isOptedIn( $wgUser ) ) {
6858 $query['opt'] = 'feedback';
@@ -73,6 +63,15 @@
7464 );
7565 }
7666
 67+ // Inserts a link into personal tools
 68+ $addLinks['acaibeta'] = array(
 69+ 'text' => SpecialOptIn::isOptedIn( $wgUser ) ?
 70+ wfMsg( 'optin-leave' ) :
 71+ wfMsg( 'optin-try' ),
 72+ 'href' => $link,
 73+ 'class' => 'no-text-transform'
 74+ );
 75+
7776 // Add the links
7877 $personal_urls = array_merge( $addLinks, $personal_urls );
7978 return true;
Index: trunk/extensions/UsabilityInitiative/OptIn/OptIn.i18n.php
@@ -18,7 +18,7 @@
1919 'optin-title-optedin' => 'Leave Beta',
2020 'optin-title-justoptedin' => 'Welcome to Beta',
2121 'optin-title-justoptedout' => 'Thank you for trying Beta',
22 - 'optin-title-feedback' => 'Give feedback',
 22+ 'optin-title-feedback' => 'Beta feedback',
2323 'optin-needlogin' => 'You need to [$1 log in] to try Beta.',
2424 'optin-intro' => 'The Wikipedia Usability Initiative has been working hard to improve the usability of Wikipedia.
2525 Would you like to try Beta?',
@@ -43,10 +43,10 @@
4444 'optin-feedback' => 'Give feedback',
4545 'optin-survey-yes' => 'Yes',
4646 'optin-survey-no' => 'No',
47 - 'optin-survey-intro' => "Thank you for trying Beta.
 47+ 'optin-survey-intro' => "Thank you for trying the Beta.
4848 We would like to know what you think about our new interface, so we would appreciate it if you filled out the optional survey below before clicking \"[[#leave|{{int:optin-submit-out}}]]\".",
49 - 'optin-survey-question-likedislike' => 'What did you like about Beta? What did you dislike about Beta?',
50 - 'optin-survey-question-whyoptout' => 'Why are you leaving Beta? (Please select all that apply.) ',
 49+ 'optin-survey-question-likedislike' => 'What did you like about the Beta? What did you dislike about the Beta?',
 50+ 'optin-survey-question-whyoptout' => 'Why are you leaving the Beta? (Please select all that apply.) ',
5151 'optin-survey-answer-whyoptout-hard' => 'It was too hard to use.',
5252 'optin-survey-answer-whyoptout-didntwork' => 'It did not function properly.',
5353 'optin-survey-answer-whyoptout-notpredictable' => 'It did not perform predictably.',
@@ -55,12 +55,12 @@
5656 'optin-survey-answer-whyoptout-didntlike-toolbar' => 'I did not like the new toolbar.',
5757 'optin-survey-answer-whyoptout-other' => 'Other reason:',
5858 'optin-survey-question-explain' => 'Please explain or elaborate on your answer above:',
59 - 'optin-survey-question-techfail' => 'Did you experience any technical failures while using Beta?',
 59+ 'optin-survey-question-techfail' => 'Have you experienced any technical failures while using the Beta?',
6060 'optin-survey-question-techfail-ifyes' => 'If yes, please elaborate or explain:',
61 - 'optin-survey-question-usedtoolbar' => 'Did you use the new expandable toolbar to edit a page?',
 61+ 'optin-survey-question-usedtoolbar' => 'Have you used the new expandable toolbar to edit a page?',
6262 'optin-survey-question-usedtoolbar-ifyes' => 'If yes, what did you like about it? What did you dislike about it?',
6363 'optin-survey-question-usedtoolbar-ifno' => 'If no, why not? Will you in the future? Please explain.',
64 - 'optin-survey-question-different' => 'What could we have done differently to keep you using our Beta?',
 64+ 'optin-survey-question-different' => 'What could we have done differently to keep you using our the Beta?',
6565 'optin-survey-question-feedback' => 'Please let us know about any other comments, concerns or thoughts you have for us - all feedback is useful!:',
6666 'optin-survey-question-browser' => 'Which browser do you use?',
6767 'optin-survey-answer-browser-ie5' => 'Internet Explorer 5',

Follow-up revisions

RevisionCommit summaryAuthorDate
r53760Followup to r53759: forgot onecatrope19:56, 25 July 2009

Status & tagging log