r53757 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53756‎ | r53757 | r53758 >
Date:19:36, 25 July 2009
Author:ialex
Status:resolved (Comments)
Tags:
Comment:
* (bug 19301) Duplicates entries in $wgAddGroups, $wgRemoveGroups, $wgGroupsAddToSelf and $wgGroupsRemoveFromSelf are no more displayed on Special:ListGroupRights
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialListgrouprights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListgrouprights.php
@@ -125,6 +125,13 @@
126126 */
127127 private static function formatPermissions( $permissions, $revoke, $add, $remove, $addSelf, $removeSelf ) {
128128 global $wgLang;
 129+
 130+ // prevent double entries if misconfigured, bug 19301
 131+ $add = array_unique( $add );
 132+ $remove = array_unique( $remove );
 133+ $addSelf = array_unique( $addSelf );
 134+ $removeSelf = array_unique( $removeSelf );
 135+
129136 $r = array();
130137 foreach( $permissions as $permission => $granted ) {
131138 //show as granted only if it isn't revoked to prevent duplicate display of permissions
Index: trunk/phase3/RELEASE-NOTES
@@ -330,6 +330,9 @@
331331 * The display of the language list on the preferences is more comply with the
332332 BCP 47 standards.
333333 * (bug 19849) Custom X-Vary-Options header now disabled unless $wgUseXVO is set
 334+* (bug 19301) Duplicates entries in $wgAddGroups, $wgRemoveGroups,
 335+ $wgGroupsAddToSelf and $wgGroupsRemoveFromSelf are no more displayed on
 336+ Special:ListGroupRights
334337
335338 == API changes in 1.16 ==
336339

Follow-up revisions

RevisionCommit summaryAuthorDate
r53926Fix for r53757 per Nikerabbit's comment: these can also be "true", only do ar...ialex08:43, 29 July 2009

Comments

#Comment by Nikerabbit (talk | contribs)   07:26, 29 July 2009

[29-Jul-2009 02:37:45] PHP Warning: array_unique() [<a href='function.array-unique'>function.array-unique</a>]: The argument should be an array in /var/www/w/includes/specials/SpecialListgrouprights.php on line 130
[29-Jul-2009 02:37:45] PHP Warning: array_unique() [<a href='function.array-unique'>function.array-unique</a>]: The argument should be an array in /var/www/w/includes/specials/SpecialListgrouprights.php on line 131

#Comment by IAlex (talk | contribs)   08:44, 29 July 2009

fixed in r53926.

Status & tagging log