r53638 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53637‎ | r53638 | r53639 >
Date:04:53, 22 July 2009
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Fixed php 5.3 reference error
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -970,7 +970,7 @@
971971 $oldtext = $this->mArticle->getContent();
972972
973973 // Run post-section-merge edit filter
974 - if ( !wfRunHooks( 'EditFilterMerged', array( $this, $text, &$this->hookError, $this->summary ) ) ) {
 974+ if ( !wfRunHooks( 'EditFilterMerged', array( &$this, $text, &$this->hookError, $this->summary ) ) ) {
975975 # Error messages etc. could be handled within the hook...
976976 wfProfileOut( $fname );
977977 return self::AS_HOOK_ERROR;

Comments

#Comment by Brion VIBBER (talk | contribs)   22:53, 21 August 2009

Fixed this correctly in r55449 - use of reference is wrong here.

Status & tagging log