r53582 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53581‎ | r53582 | r53583 >
Date:11:18, 21 July 2009
Author:raymond
Status:ok
Tags:
Comment:
(bug 18161) Fix inconsistent separators in watchlist link toolbars with "enhanced recent changes"
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -69,7 +69,7 @@
7070 private function preCacheMessages() {
7171 if( !isset( $this->message ) ) {
7272 foreach( explode(' ', 'cur diff hist minoreditletter newpageletter last '.
73 - 'blocklink history boteditletter semicolon-separator' ) as $msg ) {
 73+ 'blocklink history boteditletter semicolon-separator pipe-separator' ) as $msg ) {
7474 $this->message[$msg] = wfMsgExt( $msg, array( 'escapenoentities' ) );
7575 }
7676 }
@@ -832,12 +832,12 @@
833833 if( $allLogs ) {
834834 // don't show history link for logs
835835 } else if( $namehidden || !$block[0]->getTitle()->exists() ) {
836 - $r .= $this->message['semicolon-separator'] . $this->message['hist'] . ')';
 836+ $r .= $this->message['pipe-separator'] . $this->message['hist'] . ')';
837837 } else {
838838 $params = $queryParams;
839839 $params['action'] = 'history';
840840
841 - $r .= $this->message['semicolon-separator'] .
 841+ $r .= $this->message['pipe-separator'] .
842842 $this->skin->link(
843843 $block[0]->getTitle(),
844844 $this->message['hist'],
@@ -925,7 +925,7 @@
926926 if ( !$rc_type == RC_LOG || $rc_type == RC_NEW ) {
927927 $r .= ' (';
928928 $r .= $rcObj->curlink;
929 - $r .= $this->message['semicolon-separator'];
 929+ $r .= $this->message['pipe-separator'];
930930 $r .= $rcObj->lastlink;
931931 $r .= ')';
932932 }
@@ -1050,7 +1050,7 @@
10511051 }
10521052 # Diff and hist links
10531053 if ( $rc_type != RC_LOG ) {
1054 - $r .= ' ('. $rcObj->difflink . $this->message['semicolon-separator'];
 1054+ $r .= ' ('. $rcObj->difflink . $this->message['pipe-separator'];
10551055 $query['action'] = 'history';
10561056 $r .= $this->skin->link(
10571057 $rcObj->getTitle(),
Index: trunk/phase3/RELEASE-NOTES
@@ -308,6 +308,9 @@
309309 * (bug 15745) The edit summary link parser now handles mismatched brackets
310310 better
311311 * (bug 19839) Comments in log items are no more double escaped
 312+* (bug 19839) Comments in log items are no more double escaped
 313+* (bug 18161) Fix inconsistent separators in watchlist link toolbars with
 314+ "enhanced recent changes"
312315
313316 == API changes in 1.16 ==
314317

Follow-up revisions

RevisionCommit summaryAuthorDate
r53586follow up r53582: remove duped line :/raymond12:04, 21 July 2009
r53588follow up r53582: Move escaping to the outer message for consistency. Per sug...raymond12:17, 21 July 2009

Status & tagging log