r53523 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53522‎ | r53523 | r53524 >
Date:02:59, 20 July 2009
Author:aaron
Status:ok
Tags:
Comment:
(bug 19770) Preview remembers status field now
Modified paths:
  • /trunk/extensions/CodeReview/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRevisionView.php
@@ -35,7 +35,8 @@
3636 $view->execute();
3737 return;
3838 }
39 - $this->mStatus = $this->mStatus ? $this->mStatus : $this->mRev->getStatus();
 39+ if( $this->mStatus == '' )
 40+ $this->mStatus = $this->mRev->getStatus();
4041
4142 $redirectOnPost = $this->checkPostings();
4243 if ( $redirectOnPost ) {
@@ -247,7 +248,7 @@
248249 $repo = $this->mRepo->getName();
249250 $rev = $this->mRev->getId();
250251 return Xml::openElement( 'select', array( 'name' => 'wpStatus' ) ) .
251 - self::buildStatusList( $this->mRev->getStatus(), $this ) .
 252+ self::buildStatusList( $this->mStatus, $this ) .
252253 xml::closeElement( 'select' );
253254 } else {
254255 return htmlspecialchars( $this->statusDesc( $this->mRev->getStatus() ) );

Status & tagging log