r53522 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53521‎ | r53522 | r53523 >
Date:02:51, 20 July 2009
Author:aaron
Status:ok
Tags:
Comment:
(bug 19105) Localize status changes
Modified paths:
  • /trunk/extensions/CodeReview/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRevisionView.php
@@ -431,14 +431,29 @@
432432 // Uses messages 'code-change-status', 'code-change-tags'
433433 $line .= ' ' . wfMsgExt( "code-change-{$change->attrib}", 'parseinline', $revId );
434434 $line .= " <i>[";
 435+ // Items that were changed or set...
435436 if ( $change->removed ) {
436437 $line .= '<b>' . wfMsg( 'code-change-removed' ) . '</b> ';
437 - $line .= htmlspecialchars( $change->removed );
438 - $line .= $change->added ? "&nbsp;" : "";
 438+ // Status changes...
 439+ if( $change->attrib == 'status' ) {
 440+ $line .= wfMsgHtml( 'code-status-'.$change->removed );
 441+ $line .= $change->added ? "&nbsp;" : ""; // spacing
 442+ // Tag changes
 443+ } else if( $change->attrib == 'tags' ) {
 444+ $line .= htmlspecialchars( $change->removed );
 445+ $line .= $change->added ? "&nbsp;" : ""; // spacing
 446+ }
439447 }
 448+ // Items that were changed to something else...
440449 if ( $change->added ) {
441450 $line .= '<b>' . wfMsg( 'code-change-added' ) . '</b> ';
442 - $line .= htmlspecialchars( $change->added );
 451+ // Status changes...
 452+ if( $change->attrib == 'status' ) {
 453+ $line .= wfMsgHtml( 'code-status-'.$change->added );
 454+ // Tag changes...
 455+ } else {
 456+ $line .= htmlspecialchars( $change->added );
 457+ }
443458 }
444459 $line .= "]</i>";
445460 return "<li>$line</li>";

Status & tagging log