r53457 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53456‎ | r53457 | r53458 >
Date:21:23, 18 July 2009
Author:ialex
Status:ok
Tags:
Comment:
(bug 19759) successbox on Special:Preferences now correctly aligned on standard, nostalgia and cologneblue skins
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialPreferences.php (modified) (history)
  • /trunk/phase3/skins/common/oldshared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/oldshared.css
@@ -144,6 +144,9 @@
145145 }
146146
147147 /* preference page with js-genrated toc */
 148+#mw-pref-clear {
 149+ clear: both;
 150+}
148151 #preftoc {
149152 float: left;
150153 margin: 1em 1em 1em 1em;
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1578,7 +1578,7 @@
15791579 * to ensure that client-side caches do not keep obsolete copies of global
15801580 * styles.
15811581 */
1582 -$wgStyleVersion = '233';
 1582+$wgStyleVersion = '234';
15831583
15841584
15851585 # Server-side caching:
Index: trunk/phase3/includes/specials/SpecialPreferences.php
@@ -30,7 +30,7 @@
3131
3232 if ( $wgRequest->getCheck( 'success' ) ) {
3333 $wgOut->wrapWikiMsg(
34 - '<div class="successbox"><strong>$1</strong></div>',
 34+ '<div class="successbox"><strong>$1</strong></div><div id="mw-pref-clear"></div>',
3535 'savedprefs'
3636 );
3737 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r53458RELEASE-NOTES entry for r53457 (oops)ialex21:25, 18 July 2009
r54197Follow-up r53457: same for modern skinialex11:10, 2 August 2009

Status & tagging log