r53368 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53367‎ | r53368 | r53369 >
Date:18:05, 16 July 2009
Author:tparscal
Status:ok
Tags:
Comment:
Improved the apearance, behavior and consistency accross browsers of simple search.
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/skins/vector/images/search.png (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -779,7 +779,7 @@
780780 <?php if ( $wgVectorUseSimpleSearch ): ?>
781781 <div id="simpleSearch">
782782 <input id="searchInput" name="search" type="text" <?php echo $this->skin->tooltipAndAccesskey( 'search' ); ?> <?php if( isset( $this->data['search'] ) ): ?> value="<?php $this->text( 'search' ) ?>"<?php endif; ?> />
783 - <input id="searchButton" type='image' name='fulltext' src="<?php echo $wgStylePath ?>/vector/images/search.png" <?php echo $this->skin->tooltipAndAccesskey( 'search-fulltext' ); ?> align="top" />
 783+ <input id="searchButton" type='submit' name='fulltext' value="&nbsp;" src="<?php echo $wgStylePath ?>/vector/images/search.png" <?php echo $this->skin->tooltipAndAccesskey( 'search-fulltext' ); ?> />
784784 </div>
785785 <?php else: ?>
786786 <input id="searchInput" name="search" type="text" <?php echo $this->skin->tooltipAndAccesskey( 'search' ); ?> <?php if( isset( $this->data['search'] ) ): ?> value="<?php $this->text( 'search' ) ?>"<?php endif; ?> />
Index: trunk/phase3/skins/vector/images/search.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/phase3/skins/vector/main-ltr.css
@@ -292,19 +292,38 @@
293293 margin: 0;
294294 margin-top: 0.4em;
295295 }
296 - div#p-search div#simpleSearch input#searchInput {
297 - margin-top: 0.33em;
 296+ div#p-search div#simpleSearch {
 297+ margin-top: 0.75em;
 298+ position: relative;
298299 border: solid 1px #AAAAAA;
299 - height: 1.25em;
300 - width: 10em;
301 - padding: 0.33em;
 300+ background-color: white;
302301 background-image: url(images/search-fade.png);
 302+ background-position: top left;
303303 background-repeat: repeat-x;
304 - background-position: top left;
305304 }
 305+ div#p-search div#simpleSearch input#searchInput {
 306+ margin: 0;
 307+ border-width: 0;
 308+ padding: 0.25em;
 309+ line-height: 1em;
 310+ font-size: 9.75pt;
 311+ width: 10em;
 312+ background-color: transparent;
 313+ }
306314 div#p-search div#simpleSearch input#searchButton {
 315+ position: absolute;
 316+ top: 0;
 317+ right: 0;
 318+ margin: 0;
 319+ padding: 0;
 320+ width: 1.75em;
 321+ height: 100%;
307322 border: none;
308 - margin-left: 0.25em;
 323+ cursor: pointer;
 324+ background-color: transparent;
 325+ background-image: url(images/search.png);
 326+ background-position: center center;
 327+ background-repeat: no-repeat;
309328 }
310329 /* Panel */
311330 div#panel {
Index: trunk/phase3/skins/vector/main-rtl.css
@@ -292,19 +292,38 @@
293293 margin: 0;
294294 margin-top: 0.4em;
295295 }
296 - div#p-search div#simpleSearch input#searchInput {
297 - margin-top: 0.33em;
 296+ div#p-search div#simpleSearch {
 297+ margin-top: 0.75em;
 298+ position: relative;
298299 border: solid 1px #AAAAAA;
299 - height: 1.25em;
300 - width: 10em;
301 - padding: 0.33em;
 300+ background-color: white;
302301 background-image: url(images/search-fade.png);
 302+ background-position: top right;
303303 background-repeat: repeat-x;
304 - background-position: top right;
305304 }
 305+ div#p-search div#simpleSearch input#searchInput {
 306+ margin: 0;
 307+ border-width: 0;
 308+ padding: 0.25em;
 309+ line-height: 1em;
 310+ font-size: 9.75pt;
 311+ width: 10em;
 312+ background-color: transparent;
 313+ }
306314 div#p-search div#simpleSearch input#searchButton {
 315+ position: absolute;
 316+ top: 0;
 317+ left: 0;
 318+ margin: 0;
 319+ padding: 0;
 320+ width: 1.75em;
 321+ height: 100%;
307322 border: none;
308 - margin-right: 0.25em;
 323+ cursor: pointer;
 324+ background-color: transparent;
 325+ background-image: url(images/search.png);
 326+ background-position: center center;
 327+ background-repeat: no-repeat;
309328 }
310329 /* Panel */
311330 div#panel {

Status & tagging log