r53355 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53354‎ | r53355 | r53356 >
Date:11:00, 16 July 2009
Author:purodha
Status:reverted (Comments)
Tags:
Comment:
message contains html markup
Modified paths:
  • /trunk/extensions/FlaggedRevs/specialpages/OldReviewedPages_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/OldReviewedPages_body.php
——@@ -84,7 +84,7 @@
8585 : ""
8686 );
8787 $form .= '<br/>' .
88 - Xml::label( wfMsg('oldreviewed-size'), 'wpSize' ) .
 88+ Xml::label( wfExt('oldreviewed-size', array('parse', 'escapenoentities') ), 'wpSize' ) .
8989 Xml::input( 'size', 4, $this->size, array( 'id' => 'wpSize' ) ) . ' ' .
9090 Xml::submitButton( wfMsg( 'allpagessubmit' ) ) . "\n" .
9191 "</fieldset></form>";

Follow-up revisions

RevisionCommit summaryAuthorDate
r53402revert r53355 - the real culprit is "htmlspecialchars()" line 31 in includes/...purodha15:37, 17 July 2009

Comments

#Comment by Nikerabbit (talk | contribs)   12:20, 16 July 2009

That's not going to work. Now it is parse→escape→escape (instead of just escape). There is no html markup in the source message. escapenoentities is deprecated anyway, since &nbsp; and &#32; can now be used almost everywhere.

#Comment by Purodha (talk | contribs)   15:57, 17 July 2009

There are actually two problems here. One is outlined in the translation hints. There is markup in a translation.

The other is imho a system of message handlers, the documentation of which is sparse, the logic of which is kind of outdated, complicated, and imho partially counter-intuitive; thus inviting one to err.

#Comment by Nikerabbit (talk | contribs)   18:34, 17 July 2009

Xml-class is what it is, it cannot be fixed or worked around easily. I made some changes and additions to Internationalisation, because I couldn't find that information elsewhere.

#Comment by Werdna (talk | contribs)   18:34, 27 August 2009

Reverted in r53402.

Status & tagging log