r53316 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53315‎ | r53316 | r53317 >
Date:16:36, 15 July 2009
Author:werdna
Status:resolved (Comments)
Tags:
Comment:
Force select-or-other type fields to string values, fixing problem where stub threshold was not being properly loaded into preferences window once saved differently to the default
Modified paths:
  • /trunk/phase3/includes/HTMLForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HTMLForm.php
——@@ -647,7 +647,7 @@
648648 $selected = $valInSelect ? $value : 'other';
649649
650650 $select = new XmlSelect( $this->mName, $this->mID, $selected );
651 - $select->addOptions( $this->mParams['options'] );
 651+ $select->addOptions( array_map( 'strval', $this->mParams['options'] ) );
652652
653653 $select->setAttribute( 'class', 'mw-htmlform-select-or-other' );
654654

Follow-up revisions

RevisionCommit summaryAuthorDate
r53952Fix regression in r53316, some more intelligent handling.werdna16:20, 29 July 2009

Comments

#Comment by Nikerabbit (talk | contribs)   19:52, 24 July 2009

This causes regression in Preferences, the list of timezones is missing all but the topmost entries.

#Comment by Werdna (talk | contribs)   16:22, 29 July 2009

Hopefully resolved in r53952.

Status & tagging log