r53306 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53305‎ | r53306 | r53307 >
Date:10:35, 15 July 2009
Author:ialex
Status:ok
Tags:
Comment:
fix for r53282: split() -> explode() the former is part of POSIX regex and is deprecated since PHP 5.3
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -121,11 +121,11 @@
122122 if( $wgEnableScriptLoader ){
123123 if( strpos( $path, $wgScript ) !== false ){
124124 $reqPath = str_replace( $wgScript . '?', '', $path );
125 - $reqArgs = split( '&', $reqPath );
 125+ $reqArgs = explode( '&', $reqPath );
126126 $reqSet = array();
127127
128128 foreach( $reqArgs as $arg ){
129 - list( $key, $var ) = split( '=', $arg );
 129+ list( $key, $var ) = explode( '=', $arg );
130130 $reqSet[$key] = $var;
131131 }
132132

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53282here it is ... the upload-api, script-server, js2 (javascript phase2) branch ...dale23:52, 14 July 2009

Status & tagging log