r53297 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53296‎ | r53297 | r53298 >
Date:08:07, 15 July 2009
Author:raymond
Status:deferred
Tags:
Comment:
* Tweak message keys to be consistent
* Add extension to translatewiki.net
Modified paths:
  • /trunk/extensions/Translate/aliases.txt (modified) (history)
  • /trunk/extensions/Translate/groups/mediawiki-defines.txt (modified) (history)
  • /trunk/extensions/freenodeChat/freenodeChat.i18n.php (modified) (history)
  • /trunk/extensions/freenodeChat/freenodeChat.php (modified) (history)
  • /trunk/extensions/freenodeChat/freenodeChat_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/groups/mediawiki-defines.txt
@@ -362,6 +362,8 @@
363363 ignored = framedvideo_max_height, framedvideo_allow_full_screen, framedvideo_force_allow_full_screen, framedvideo_force_frames
364364 ignored = framedvideo_force_position
365365
 366+Freenode Chat
 367+
366368 Fundraiser Portal
367369
368370 Gadgets
Index: trunk/extensions/Translate/aliases.txt
@@ -118,6 +118,9 @@
119119 Flagged revisions
120120 file = FlaggedRevs/language/FlaggedRevs.alias.php
121121
 122+Freenode Chat
 123+file = freenodeChat/freenodeChat.alias.php
 124+
122125 Gadgets
123126 file = Gadgets/Gadgets.alias.php
124127
Index: trunk/extensions/freenodeChat/freenodeChat_body.php
@@ -19,7 +19,7 @@
2020 $this->setHeaders();
2121
2222 // Introduction message, explaining to users what this is etc.
23 - $wgOut->addWikiMsg( 'freenode-chat-header' );
 23+ $wgOut->addWikiMsg( 'freenodechat-header' );
2424
2525 // Prepare query string to pass to widget.
2626 $queryAssoc = array(
Index: trunk/extensions/freenodeChat/freenodeChat.i18n.php
@@ -9,21 +9,21 @@
1010 /** English */
1111 $messages['en'] = array(
1212 'freenodechat' => 'Freenode Chat',
13 - 'freenode-chat-desc' => 'Adds a [[Special:FreenodeChat|special page]] used to chat in real time with other wiki users (using freenode web IRC client)',
14 - 'freenode-chat-header' => 'This special page allows you to collaborate in real time with other users of the wiki.
 13+ 'freenodechat-desc' => 'Adds a [[Special:FreenodeChat|special page]] used to chat in real time with other wiki users (using freenode web IRC client)',
 14+ 'freenodechat-header' => 'This special page allows you to collaborate in real time with other users of the wiki.
1515 To connect simply press the "Connect" button.
1616 If you are logged in your nickname will have been prefilled.
1717 Anonymous users has to insert a nickname of their choice in "Nickname" field.',
18 - 'right-freenode-chat' => 'Allowed to use freenode chat',
 18+ 'right-freenodechat' => 'Allowed to use freenode chat',
1919 );
2020
2121 /** Italian (Italiano) */
2222 $messages['it'] = array(
2323 'freenodechat' => 'Chat Freenode',
24 - 'freenode-chat-desc' => 'Aggiunge una [[Special:FreenodeChat|pagina speciale]] usata per chattare in tempo reale con altri utenti wiki (usando il client web IRC di freenode)',
25 - 'freenode-chat-header' => 'Questa pagina speciale ti permette di collaborare in tempo reale con altri utenti della wiki.
 24+ 'freenodechat-desc' => 'Aggiunge una [[Special:FreenodeChat|pagina speciale]] usata per chattare in tempo reale con altri utenti wiki (usando il client web IRC di freenode)',
 25+ 'freenodechat-header' => 'Questa pagina speciale ti permette di collaborare in tempo reale con altri utenti della wiki.
2626 Per connetterti premi semplicemente il pulsante "Connect".
2727 Se sei giàloggato il tuo nickname saràpreinserito.
2828 Gli utenti anonimi devono inserirne uno a loro scelta nel campo "Nickname"',
29 - 'right-freenode-chat' => 'Autorizzato a usare la chat',
 29+ 'right-freenodechat' => 'Autorizzato a usare la chat',
3030 );
Index: trunk/extensions/freenodeChat/freenodeChat.php
@@ -19,8 +19,8 @@
2020 'path' => __FILE__,
2121 'name' => 'Freenode Chat',
2222 'description' => 'Adds a special page used to chat in real time with other wiki users (using freenode web IRC client).',
23 - 'descriptionmsg' => 'freenode-chat-desc',
24 - 'version' => '0.1',
 23+ 'descriptionmsg' => 'freenodechat-desc',
 24+ 'version' => '0.1.1',
2525 'author' => array( 'Robert Leverington', 'Marco 27' )
2626 );
2727
@@ -36,7 +36,7 @@
3737 $wgExtensionAliasesFiles[ 'FreenodeChat' ] = $dir . 'freenodeChat.alias.php';
3838
3939 // Permissions.
40 -$wgAvailableRights[] = 'freenode-chat';
41 -$wgGroupPermissions[ '*' ][ 'freenode-chat' ] = true;
42 -$wgGroupPermissions[ 'user' ][ 'freenode-chat' ] = true;
43 -$wgGroupPermissions[ 'sysop' ][ 'freenode-chat' ] = true;
 40+$wgAvailableRights[] = 'freenodechat';
 41+$wgGroupPermissions[ '*' ][ 'freenodechat' ] = true;
 42+$wgGroupPermissions[ 'user' ][ 'freenodechat' ] = true;
 43+$wgGroupPermissions[ 'sysop' ][ 'freenodechat' ] = true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r53308Fix parser tests for r52213....catrope11:29, 15 July 2009
r53329Follow-up r53297: fix special page name and encoding in 'it' messages...raymond20:35, 15 July 2009

Status & tagging log