r53290 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r53289‎ \| r53290 \| r53291 >
Date:	06:26, 15 July 2009
Author:	nikerabbit
Status:	resolved (Comments)
Tags:
Comment:	Add hidden title, would otherwise go to the main page with ugly urls for some reason
Modified paths:	/trunk/phase3/includes/specials/SpecialAllmessages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialAllmessages.php
—	—	@@ -52,6 +52,7 @@
53	53	ksort( $languages );
54	54
55	55	$out = "<form method=\"get\" action=\"$url\"><fieldset>\n" .
	56	+ Xml::hidden( 'title', $this->getTitle() ) .
56	57	Xml::element( 'legend', null, wfMsg( 'allmessages' ) ) . "<table><tr>\n" .
57	58	"<td class=\"mw-label\">" .
58	59	Xml::label( wfMsg('allmessages-prefix'), 'am-form-prefix' ) .

Follow-up revisions

Revision	Commit summary	Author	Date
r73332	Fix for r53290	nikerabbit	15:35, 19 September 2010

Comments

#Comment by Juliano (talk | contribs) 14:49, 19 September 2010

->__toString() is broken in PHP 5.1.6 (which is still above the minimum requirements for MediaWiki). The noticeable effect is that it will render a hidden input field with name="title" value="Object", and a PHP Error in the logs.

Please, make add a ->getPrefixedText().

Status & tagging log

15:36, 19 September 2010 Nikerabbit (talk | contribs) changed the status of r53290 [removed: fixme added: resolved]
14:49, 19 September 2010 Juliano (talk | contribs) changed the status of r53290 [removed: ok added: fixme]
17:03, 22 August 2009 Brion VIBBER (talk | contribs) changed the status of r53290 [removed: new added: ok]