r53221 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53220‎ | r53221 | r53222 >
Date:12:13, 14 July 2009
Author:werdna
Status:deferred
Tags:
Comment:
Edit override on postDivClass to apply the original class too, it breaks JS not to
Modified paths:
  • /trunk/extensions/LiquidThreads/pages/NewUserMessagesView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/pages/NewUserMessagesView.php
@@ -60,11 +60,14 @@
6161 }
6262
6363 function postDivClass( $thread ) {
 64+ $origClass = parent::postDivClass( $thread );
 65+
6466 $topid = $thread->topmostThread()->id();
 67+
6568 if ( in_array( $thread->id(), $this->targets[$topid] ) )
66 - return 'lqt_post_new_message';
67 - else
68 - return 'lqt_post';
 69+ return "$origClass lqt_post_new_message";
 70+
 71+ return $origClass;
6972 }
7073
7174 function showOnce() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r53222Add !important to CSS definition, to fix regression in r53221werdna12:17, 14 July 2009

Status & tagging log