r53212 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53211‎ | r53212 | r53213 >
Date:07:35, 14 July 2009
Author:raymond
Status:deferred
Tags:
Comment:
follow-up r53093: split readerfeedback in translatewiki too
Modified paths:
  • /trunk/extensions/Translate/Translate.i18n.php (modified) (history)
  • /trunk/extensions/Translate/aliases.txt (modified) (history)
  • /trunk/extensions/Translate/groups/MediaWikiExtensions.php (modified) (history)
  • /trunk/extensions/Translate/groups/mediawiki-defines.txt (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/groups/MediaWikiExtensions.php
@@ -158,6 +158,7 @@
159159 'ext-0-wikitravel' => 'AllWikitravelExtensionsGroup',
160160 'ext-collection-0-all' => 'AllCollectionExtensionsGroup',
161161 'ext-flaggedrevs-0-all' => 'AllFlaggedRevsExtensionsGroup',
 162+ 'ext-readerfeedback-0-all'=> 'AllReaderFeedbackExtensionsGroup',
162163 'ext-translate-0-all' => 'AllTranslateExtensionsGroup',
163164 'ext-socialprofile-0-all' => 'AllSocialProfileExtensionsGroup',
164165 'ext-uniwiki-0-all' => 'AllUniwikiExtensionsGroup',
@@ -534,12 +535,9 @@
535536
536537 protected $flaggedrevsextensions = array(
537538 'ext-flaggedrevs-flaggedrevs',
538 - 'ext-flaggedrevs-likedpages',
539539 'ext-flaggedrevs-oldreviewedpages',
540540 'ext-flaggedrevs-problemchanges',
541 - 'ext-flaggedrevs-problempages',
542541 'ext-flaggedrevs-qualityoversight',
543 - 'ext-flaggedrevs-ratinghistory',
544542 'ext-flaggedrevs-reviewedpages',
545543 'ext-flaggedrevs-stabilization',
546544 'ext-flaggedrevs-stablepages',
@@ -560,6 +558,32 @@
561559 }
562560 }
563561
 562+class AllReaderFeedbackExtensionsGroup extends AllMediawikiExtensionsGroup {
 563+ protected $label = 'ReaderFeedback';
 564+ protected $id = 'ext-readerfeedback-0-all';
 565+ protected $meta = true;
 566+
 567+ protected $classes = null;
 568+ protected $description = '{{int:translate-group-desc-readerfeedback}}';
 569+
 570+ protected $flaggedrevsextensions = array(
 571+ 'ext-readerfeedback-readerfeedback',
 572+ 'ext-readerfeedback-likedpages',
 573+ 'ext-readerfeedback-problempages',
 574+ 'ext-readerfeedback-ratinghistory',
 575+ );
 576+
 577+ protected function init() {
 578+ if ( $this->classes === null ) {
 579+ $this->classes = array();
 580+ $classes = MessageGroups::singleton()->getGroups();
 581+ foreach ( $this->flaggedrevsextensions as $key ) {
 582+ $this->classes[$key] = $classes[$key];
 583+ }
 584+ }
 585+ }
 586+}
 587+
564588 class AllSocialProfileExtensionsGroup extends AllMediawikiExtensionsGroup {
565589 protected $label = 'Social Profile';
566590 protected $id = 'ext-socialprofile-0-all';
Index: trunk/extensions/Translate/groups/mediawiki-defines.txt
@@ -295,11 +295,6 @@
296296 optional = revreview-toggle, revreview-ak-review, accesskey-ca-current, accesskey-ca-stable
297297 descmsg = flaggedrevs-desc
298298
299 -Flagged Revisions - Liked Pages
300 -id = ext-flaggedrevs-likedpages
301 -file = FlaggedRevs/language/LikedPages.i18n.php
302 -descmsg = likedpages
303 -
304299 Flagged Revisions - Old Reviewed Pages
305300 id = ext-flaggedrevs-oldreviewedpages
306301 file = FlaggedRevs/language/OldReviewedPages.i18n.php
@@ -310,21 +305,11 @@
311306 file = FlaggedRevs/language/ProblemChanges.i18n.php
312307 descmsg = problemchanges
313308
314 -Flagged Revisions - Problem Pages
315 -id = ext-flaggedrevs-problempages
316 -file = FlaggedRevs/language/ProblemPages.i18n.php
317 -descmsg = problempages
318 -
319309 Flagged Revisions - Quality Oversight
320310 id = ext-flaggedrevs-qualityoversight
321311 file = FlaggedRevs/language/QualityOversight.i18n.php
322312 descmsg = qualityoversight
323313
324 -Flagged Revisions - Rating History
325 -id = ext-flaggedrevs-ratinghistory
326 -file = FlaggedRevs/language/RatingHistory.i18n.php
327 -descmsg = ratinghistory
328 -
329314 Flagged Revisions - Reviewed Pages
330315 id = ext-flaggedrevs-reviewedpages
331316 file = FlaggedRevs/language/ReviewedPages.i18n.php
@@ -653,6 +638,26 @@
654639 Random Users With Avatars
655640 descmsg = random-users-avatars-desc
656641
 642+Reader Feedback
 643+id = ext-readerfeedback-readerfeedback
 644+file = ReaderFeedback/language/ReaderFeedback.i18n.php
 645+descmsg = readerfeedback
 646+
 647+Reader Feedback - Liked Pages
 648+id = ext-readerfeedback-likedpages
 649+file = ReaderFeedback/language/LikedPages.i18n.php
 650+descmsg = likedpages
 651+
 652+Reader Feedback - Problem Pages
 653+id = ext-readerfeedback-problempages
 654+file = ReaderFeedback/language/ProblemPages.i18n.php
 655+descmsg = problempages
 656+
 657+Reader Feedback - Rating History
 658+id = ext-readerfeedback-ratinghistory
 659+file = ReaderFeedback/language/RatingHistory.i18n.php
 660+descmsg = ratinghistory
 661+
657662 Record Admin
658663 ignored = recordadmin-title
659664
Index: trunk/extensions/Translate/aliases.txt
@@ -220,6 +220,9 @@
221221 Random in category
222222 file = RandomInCategory/SpecialRandomincategory.alias.php
223223
 224+Reader Feedback
 225+file = ReaderFeedback/language/ReaderFeedback.alias.php
 226+
224227 Record admin
225228 file = RecordAdmin/RecordAdmin.alias.php
226229
Index: trunk/extensions/Translate/Translate.i18n.php
@@ -222,6 +222,7 @@
223223 'translate-group-desc-mediawikiextensions' => 'Meta message group containing all messages for supported extensions for MediaWiki',
224224 'translate-group-desc-collection' => 'Meta message group containing all messages for the MediaWiki extension [http://www.mediawiki.org/wiki/Extension:Collection Collection]',
225225 'translate-group-desc-flaggedrevs' => 'Meta message group containing all messages for the MediaWiki extension [http://www.mediawiki.org/wiki/Extension:FlaggedRevs FlaggedRevs]',
 226+ 'translate-group-desc-readerfeedback' => 'Meta message group containing all messages for the MediaWiki extension [http://www.mediawiki.org/wiki/Extension:ReaderFeedback ReaderFeedback]',
226227 'translate-group-desc-socialprofile' => 'Meta message group containing all messages for extensions related to the MediaWiki extension [http://www.mediawiki.org/wiki/Extension:SocialProfile Social Profile]',
227228 'translate-group-desc-translate' => 'Meta message group containing all messages for the MediaWiki extension [http://www.mediawiki.org/wiki/Extension:Translate Translate]',
228229 'translate-group-desc-wikiaextensions' => 'Meta message group containing all messages for supported MediaWiki extensions used by [http://www.wikia.com Wikia]',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53093Spitting out ReaderFeedback stuff part Iaaron03:26, 11 July 2009

Status & tagging log