r53211 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53210‎ | r53211 | r53212 >
Date:07:25, 14 July 2009
Author:tparscal
Status:ok
Tags:
Comment:
More IE fixes for RTL, getting quite close now.
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
——@@ -703,7 +703,7 @@
704704 if ( count( $this->data[ 'variant_urls' ] ) > 0 ) {
705705 ?>
706706 <div id="variants" class="vectorMenu">
707 - <h5><span><?php $this->msg('variants') ?></span><a href="#">&nbsp;</a></h5>
 707+ <h5><span><?php $this->msg('variants') ?></span><a href="#"></a></h5>
708708 <div class="menu">
709709 <ul <?php $this->html('userlangattributes') ?>>
710710 <?php foreach ($this->data['variant_urls'] as $key => $link ): ?>
——@@ -733,7 +733,7 @@
734734 if ( count( $this->data[ 'action_urls' ] ) > 0 ) {
735735 ?>
736736 <div id="p-cactions" class="vectorMenu">
737 - <h5><span><?php $this->msg('actions') ?></span><a href="#">&nbsp;</a></h5>
 737+ <h5><span><?php $this->msg('actions') ?></span><a href="#"></a></h5>
738738 <div class="menu">
739739 <ul <?php $this->html('userlangattributes') ?>>
740740 <?php foreach ($this->data['action_urls'] as $key => $link ): ?>
——@@ -775,6 +775,7 @@
776776 </form>
777777 </div>
778778 <?php
 779+
779780 break;
780781 }
781782 echo "\n<!-- /{$name} -->\n";
Index: trunk/phase3/skins/vector/main-ltr.css
——@@ -168,6 +168,7 @@
169169 padding-top: 1.25em;
170170 }
171171 /* IGNORED BY IE6 */
 172+ /* @noflip */
172173 div.vectorTabs a > span {
173174 float: left;
174175 display: block;
——@@ -190,12 +191,14 @@
191192 /* @noflip */
192193 div.vectorMenu {
193194 float: left;
 195+ direction: ltr;
194196 }
195197 div.vectorMenu {
196198 background-image: url(images/arrow-down-icon.png);
197199 background-position: center center;
198200 background-repeat: no-repeat;
199201 }
 202+ /* @noflip */
200203 div.vectorMenu h5 {
201204 float: left;
202205 }
——@@ -214,6 +217,7 @@
215218 display: block;
216219 }
217220 div.vectorMenu div.menu {
 221+ position: relative;
218222 display: none;
219223 clear: both;
220224 }
——@@ -233,6 +237,7 @@
234238 div.vectorMenu li {
235239 padding: 0;
236240 margin: 0;
 241+ text-align: left;
237242 }
238243 /* OVERRIDDEN BY COMPLIANT BROWSERS */
239244 div.vectorMenu li a {
——@@ -252,13 +257,13 @@
253258 float: left;
254259 }
255260 div#p-search {
256 - margin-right: 0.75em;
 261+ margin-right: 0.5em;
 262+ margin-left: 0.5em;
257263 }
258264 div#p-search form,
259265 div#p-search input {
260 - float: left;
 266+ margin: 0;
261267 margin-top: 0.4em;
262 - margin-left: 0.25em;
263268 }
264269 /* Panel */
265270 div#panel {
Index: trunk/phase3/skins/vector/main-rtl.css
——@@ -168,8 +168,9 @@
169169 padding-top: 1.25em;
170170 }
171171 /* IGNORED BY IE6 */
 172+ /* @noflip */
172173 div.vectorTabs a > span {
173 - float: right;
 174+ float: left;
174175 display: block;
175176 }
176177 div.vectorTabs li.selected a,
——@@ -190,14 +191,16 @@
191192 /* @noflip */
192193 div.vectorMenu {
193194 float: left;
 195+ direction: ltr;
194196 }
195197 div.vectorMenu {
196198 background-image: url(images/arrow-down-icon.png);
197199 background-position: center center;
198200 background-repeat: no-repeat;
199201 }
 202+ /* @noflip */
200203 div.vectorMenu h5 {
201 - float: right;
 204+ float: left;
202205 }
203206 /* OVERRIDDEN BY COMPLIANT BROWSERS */
204207 div.vectorMenu h5 a {
——@@ -214,6 +217,7 @@
215218 display: block;
216219 }
217220 div.vectorMenu div.menu {
 221+ position: relative;
218222 display: none;
219223 clear: both;
220224 }
——@@ -233,6 +237,7 @@
234238 div.vectorMenu li {
235239 padding: 0;
236240 margin: 0;
 241+ text-align: right;
237242 }
238243 /* OVERRIDDEN BY COMPLIANT BROWSERS */
239244 div.vectorMenu li a {
——@@ -252,13 +257,13 @@
253258 float: left;
254259 }
255260 div#p-search {
256 - margin-left: 0.75em;
 261+ margin-left: 0.5em;
 262+ margin-right: 0.5em;
257263 }
258264 div#p-search form,
259265 div#p-search input {
260 - float: right;
 266+ margin: 0;
261267 margin-top: 0.4em;
262 - margin-right: 0.25em;
263268 }
264269 /* Panel */
265270 div#panel {

Follow-up revisions

RevisionCommit summaryAuthorDate
r53410Merging UI fixes from trunk; second batch from http://www.mediawiki.org/wiki/......brion18:05, 17 July 2009

Status & tagging log