r53191 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53190‎ | r53191 | r53192 >
Date:20:26, 13 July 2009
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Made text area match up to right side of toolbar.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.css
——@@ -4,7 +4,7 @@
55 form#editform {
66 margin: 0;
77 padding: 0;
8 - margin-right: 5px;
 8+ margin-right: 2px !important;
99 }
1010 body.rtl form#editform {
1111 padding-right: 0;
——@@ -12,8 +12,9 @@
1313 }
1414 textarea#wpTextbox1 {
1515 border: solid silver 1px;
16 - padding: 0;
17 - margin: 0;
 16+ padding: 0 !important;
 17+ margin: 0 !important;
 18+ width: 100%;
1819 }
1920 /* ... */
2021 div#edittoolbar {

Follow-up revisions

RevisionCommit summaryAuthorDate
r53410Merging UI fixes from trunk; second batch from http://www.mediawiki.org/wiki/......brion18:05, 17 July 2009

Comments

#Comment by Simetrical (talk | contribs)   00:10, 14 July 2009

You seem to use !important a lot more than necessary. Do these really need it? They have very high specificity already due to the id selector. You shouldn't use !important unless you really need it, since it's distracting and will gratuitously mess other rules up. Usually specificity will handle everything very intuitively, with more specific selectors overriding more general ones.

Status & tagging log