r53154 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53153‎ | r53154 | r53155 >
Date:03:49, 13 July 2009
Author:aaron
Status:ok
Tags:
Comment:
Follow up to r53153: wasn't just a typo...also the wrong var...added the correct rev_timestamp again. This was broken from r49076.
Modified paths:
  • /trunk/extensions/FlaggedRevs/specialpages/StableVersions_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/StableVersions_body.php
@@ -56,7 +56,7 @@
5757
5858 public function formatRow( $row ) {
5959 global $wgLang, $wgUser;
60 -
 60+ $rdatim = $wgLang->timeanddate( wfTimestamp( TS_MW, $row->rev_timestamp ), true );
6161 $fdatim = $wgLang->timeanddate( wfTimestamp( TS_MW, $row->fr_timestamp ), true );
6262 $fdate = $wgLang->date( wfTimestamp( TS_MW, $row->fr_timestamp ), true );
6363 $ftime = $wgLang->time( wfTimestamp( TS_MW, $row->fr_timestamp ), true );
@@ -64,12 +64,10 @@
6565 $fdatim,
6666 $this->skin->userLink( $row->fr_user, $row->user_name ) .
6767 ' ' . $this->skin->userToolLinks( $row->fr_user, $row->user_name ),
68 - $fdate, $ftime, $row->user_name );
69 -
 68+ $fdate, $ftime, $row->user_name
 69+ );
7070 $lev = ( $row->fr_quality >=1 ) ? wfMsgHtml('hist-quality') : wfMsgHtml('hist-stable');
71 - $link = $this->skin->makeKnownLinkObj( $this->page, $ftime,
72 - 'stableid='.$row->fr_rev_id );
73 -
 71+ $link = $this->skin->makeKnownLinkObj( $this->page, $rdatim, 'stableid='.$row->fr_rev_id );
7472 return '<li>'.$link.' ('.$review.') <strong>['.$lev.']</strong></li>';
7573 }
7674 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49076Fix regression from r49061: Restore sequence of paramters....raymond14:45, 31 March 2009
r53153fixed var typoaaron03:37, 13 July 2009

Status & tagging log