r53060 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r53059‎ \| r53060 \| r53061 >
Date:	16:12, 10 July 2009
Author:	tparscal
Status:	deferred
Tags:
Comment:	Solved rg vulnerability in UsabilityInitiative extension. IMPORTANT! YOU MUST NOW INCLUDE MODULES DIRECTLY OR THING MAY BREAK!
Modified paths:	/trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php (modified) (history) /trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.php (modified) (history) /trunk/extensions/UsabilityInitiative/NavigableTOC/NavigableTOC.php (modified) (history) /trunk/extensions/UsabilityInitiative/OptIn/OptIn.php (modified) (history) /trunk/extensions/UsabilityInitiative/PrefStats/PrefStats.php (modified) (history) /trunk/extensions/UsabilityInitiative/UsabilityInitiative.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.php
—	—	@@ -8,8 +8,9 @@
9	9	* This file contains the main include file for the UsabilityInitiative
10	10	* extension of MediaWiki.
11	11	*
12		~~- * Usage: Add the following line in LocalSettings.php:~~
13		~~- * require_once( "$IP/extensions/UsabilityInitiative/UsabilityInitiative.php" );~~
	12	+ * Usage: Inlcude the modules you want to use specifically by adding a line in
	13	+ * LocalSettings.php for each of them like this:
	14	+ * require_once( "$IP/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php" );
14	15	*
15	16	* @author Trevor Parscal <tparscal@wikimedia.org>
16	17	* Allow "or a later version" here?
—	—	@@ -42,12 +43,6 @@
43	44	$wgExtensionMessagesFiles['UsabilityInitiative'] =
44	45	dirname( __FILE__ ) . "/UsabilityInitiative.i18n.php";
45	46
46		~~-// Includes sub-extensions~~
47		~~-require_once( dirname( __FILE__ ) . "/EditToolbar/EditToolbar.php" );~~
48		~~-require_once( dirname( __FILE__ ) . "/EditWarning/EditWarning.php" );~~
49		~~-require_once( dirname( __FILE__ ) . "/PrefStats/PrefStats.php" );~~
50		~~-require_once( dirname( __FILE__ ) . "/OptIn/OptIn.php" );~~
51		-
52	47	// Registers Hooks
53	48	$wgHooks['AjaxAddScript'][] = 'UsabilityInitiativeHooks::addJs';
54	49	$wgHooks['BeforePageDisplay'][] = 'UsabilityInitiativeHooks::addCss';
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php
—	—	@@ -8,7 +8,8 @@
9	9	* This file contains the include file for the EditToolbar portion of the
10	10	* UsabilityInitiative extension of MediaWiki.
11	11	*
12		~~- * Usage: This file is included automatically by ../UsabilityInitiative.php~~
	12	+ * Usage: Include the following line in your LocalSettings.php
	13	+ * require_once( "$IP/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php" );
13	14	*
14	15	* @author Trevor Parscal <tparscal@wikimedia.org>
15	16	* @license GPL v2 or later
—	—	@@ -40,6 +41,9 @@
41	42	'descriptionmsg' => 'edittoolbar-desc',
42	43	);
43	44
	45	+// Includes parent extension
	46	+require_once( dirname( dirname( __FILE__ ) ) . "/UsabilityInitiative.php" );
	47	+
44	48	// Adds Autoload Classes
45	49	$wgAutoloadClasses['EditToolbarHooks'] =
46	50	dirname( __FILE__ ) . '/EditToolbar.hooks.php';
Index: trunk/extensions/UsabilityInitiative/OptIn/OptIn.php
—	—	@@ -8,7 +8,8 @@
9	9	* This file contains the include file for the OptIn portion of the
10	10	* UsabilityInitiative extension of MediaWiki.
11	11	*
12		~~- * Usage: This file is included automatically by ../UsabilityInitiative.php~~
	12	+ * Usage: Include the following line in your LocalSettings.php
	13	+ * require_once( "$IP/extensions/UsabilityInitiative/OptIn/OptIn.php" );
13	14	*
14	15	* @author Roan Kattouw <roan.kattouw@gmail.com>
15	16	* @license GPL v2 or later
—	—	@@ -107,6 +108,9 @@
108	109	'descriptionmsg' => 'optin-desc',
109	110	);
110	111
	112	+// Includes parent extension
	113	+require_once( dirname( dirname( __FILE__ ) ) . "/UsabilityInitiative.php" );
	114	+
111	115	// Adds Autoload Classes
112	116	$wgAutoloadClasses['SpecialOptIn'] =
113	117	dirname( __FILE__ ) . '/SpecialOptIn.php';
Index: trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.php
—	—	@@ -8,7 +8,8 @@
9	9	* This file contains the include file for the EditWarning portion of the
10	10	* UsabilityInitiative extension of MediaWiki.
11	11	*
12		~~- * Usage: This file is included automatically by ../UsabilityInitiative.php~~
	12	+ * Usage: Include the following line in your LocalSettings.php
	13	+ * require_once( "$IP/extensions/UsabilityInitiative/EditWarning/EditWarning.php" );
13	14	*
14	15	* @author Roan Kattouw <roan.kattouw@gmail.com>
15	16	* @license GPL v2 or later
—	—	@@ -32,6 +33,9 @@
33	34	'descriptionmsg' => 'editwarning-desc',
34	35	);
35	36
	37	+// Includes parent extension
	38	+require_once( dirname( dirname( __FILE__ ) ) . "/UsabilityInitiative.php" );
	39	+
36	40	// Adds Autoload Classes
37	41	$wgAutoloadClasses['EditWarningHooks'] =
38	42	dirname( __FILE__ ) . '/EditWarning.hooks.php';
Index: trunk/extensions/UsabilityInitiative/PrefStats/PrefStats.php
—	—	@@ -8,7 +8,8 @@
9	9	* This file contains the include file for the EditWarning portion of the
10	10	* UsabilityInitiative extension of MediaWiki.
11	11	*
12		~~- * Usage: This file is included automatically by ../UsabilityInitiative.php~~
	12	+ * Usage: Include the following line in your LocalSettings.php
	13	+ * require_once( "$IP/extensions/UsabilityInitiative/PrefStats/PrefStats.php" );
13	14	*
14	15	* @author Roan Kattouw <roan.kattouw@gmail.com>
15	16	* @license GPL v2 or later
—	—	@@ -43,6 +44,9 @@
44	45	'descriptionmsg' => 'prefstats-desc',
45	46	);
46	47
	48	+// Includes parent extension
	49	+require_once( dirname( dirname( __FILE__ ) ) . "/UsabilityInitiative.php" );
	50	+
47	51	// Adds Autoload Classes
48	52	$wgAutoloadClasses['PrefStatsHooks'] =
49	53	dirname( __FILE__ ) . '/PrefStats.hooks.php';
Index: trunk/extensions/UsabilityInitiative/NavigableTOC/NavigableTOC.php
—	—	@@ -8,7 +8,8 @@
9	9	* This file contains the include file for the NavigableTOC portion of the
10	10	* UsabilityInitiative extension of MediaWiki.
11	11	*
12		~~- * Usage: This file is included automatically by ../UsabilityInitiative.php~~
	12	+ * Usage: Include the following line in your LocalSettings.php
	13	+ * require_once( "$IP/extensions/UsabilityInitiative/NavigableTOC/NavigableTOC.php" );
13	14	*
14	15	* @author Roan Kattouw <roan.kattouw@gmail.com>
15	16	* @license GPL v2 or later
—	—	@@ -32,6 +33,9 @@
33	34	'descriptionmsg' => 'navigabletoc-desc',
34	35	);
35	36
	37	+// Includes parent extension
	38	+require_once( dirname( dirname( __FILE__ ) ) . "/UsabilityInitiative.php" );
	39	+
36	40	// Adds Autoload Classes
37	41	$wgAutoloadClasses['NavigableTOCHooks'] =
38	42	dirname( __FILE__ ) . '/NavigableTOC.hooks.php';

Status & tagging log

00:20, 14 September 2011 Meno25 (talk | contribs) changed the status of r53060 [removed: old added: deferred]
01:02, 14 November 2010 Reedy (talk | contribs) changed the status of r53060 [removed: new added: old]
16:47, 27 October 2009 Catrope (talk | contribs) changed the tags for r53060 [removed: acaifix]
20:33, 21 July 2009 Trevor Parscal (WMF) (talk | contribs) changed the tags for r53060 [added: acaifix]