r53059 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53058‎ | r53059 | r53060 >
Date:15:52, 10 July 2009
Author:catrope
Status:deferred
Tags:
Comment:
OptIn: Move hidden field back into the form
Modified paths:
  • /trunk/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php
@@ -125,7 +125,6 @@
126126 $this->showOptInButtons();
127127 $wgOut->addWikiMsg( 'optin-improvements' );
128128 }
129 - $wgOut->addHTML( Xml::hidden( 'opt', $opt ) );
130129 }
131130
132131 function showOptInButtons() {
@@ -202,13 +201,14 @@
203202 UsabilityInitiativeHooks::addStyle( 'OptIn/OptIn.css',
204203 $wgOptInStyleVersion );
205204
206 - $retval .= Xml::openElement(
 205+ $retval = Xml::openElement(
207206 'form', array(
208207 'method' => 'post',
209208 'action' => $this->getTitle( $this->mOrigin )->getLinkURL(),
210209 'id' => 'optin-survey',
211210 )
212211 );
 212+ $retval .= Xml::hidden( 'opt', 'out' );
213213 $retval .= Xml::openElement( 'dl' );
214214 foreach ( $wgOptInSurvey as $id => $question ) {
215215 switch ( $question['type'] ) {

Status & tagging log