r53032 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53031‎ | r53032 | r53033 >
Date:03:22, 10 July 2009
Author:dantman
Status:deferred
Tags:
Comment:
MW.org talkpage "#Bug?", issue when message has something that doesn't return a proper title object.
Modified paths:
  • /trunk/extensions/WikiCategoryTagCloud/WikiCategoryTagCloud.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiCategoryTagCloud/WikiCategoryTagCloud.php
@@ -53,7 +53,8 @@
5454 $titles[0] = explode( "\n", wfMsg( 'tagcloudpages' ) );
5555
5656 for ( $i = 0; $i < count( $titles ); $i++ ) {
57 - Title::newFromText( $titles[$i] )->invalidateCache();
 57+ $t = Title::newFromText( $titles[$i] );
 58+ if( $t ) $t->invalidateCache();
5859 }
5960 return true;
6061 }

Status & tagging log