r53031 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53030‎ | r53031 | r53032 >
Date:03:15, 10 July 2009
Author:dantman
Status:deferred
Tags:
Comment:
Bugfix from MW.org talkpage
Modified paths:
  • /trunk/extensions/WikiCategoryTagCloud/WikiCategoryTagCloud.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiCategoryTagCloud/WikiCategoryTagCloud.php
@@ -126,7 +126,7 @@
127127 $textSize = $MIN_SIZE + ( $INCREASE_FACTOR * ( $tags[$i][1] ) ) / ( $max );
128128 $title = Title::makeTitle( NS_CATEGORY, $tags[$i][0] );
129129 $style = $link_style;
130 - if ( $style != '' && $style { -1 } != ';' ) $style .= ';';
 130+ if ( $style != '' && substr($style, -1) != ';' ) $style .= ';';
131131 $style .= "font-size: {$textSize}%;";
132132 $currentRow = "<a class=\"" . implode( ' ', $link_classes ) . "\" style=\"{$style}\" href=\"" . $title->getLocalURL() . "\">" . $title->getText() . "</a>&nbsp; ";
133133 $htmlOut = $htmlOut . $currentRow;
@@ -143,4 +143,4 @@
144144 return htmlspecialchars( $matches[1] );
145145 }
146146 }
147 -}
\ No newline at end of file
 147+}

Status & tagging log