r52945 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52944‎ | r52945 | r52946 >
Date:21:16, 8 July 2009
Author:dale
Status:deferred
Tags:
Comment:
updated width of mvAdvFirefogg input (save ogg file was wrapping)
Modified paths:
  • /branches/new-upload/phase3/js2/mwEmbed/example_usage/Firefogg_Make_Advanced.html (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libAddMedia/mvAdvFirefogg.js (modified) (history)

Diff [purge]

Index: branches/new-upload/phase3/js2/mwEmbed/example_usage/Firefogg_Make_Advanced.html
@@ -2,7 +2,7 @@
33 <html><head>
44 <meta http-equiv="content-type" content="text/html; charset=UTF-8">
55 <title>Firefogg - Make Ogg Video in your Browser</title>
6 - <script type="text/javascript" src="../jsScriptLoader.php?class=mv_embed,window.jQuery,mvBaseUploadInterface,mvFirefogg,mvAdvFirefogg,$j.ui,$j.ui.progressbar,$j.ui.dialog,$j.cookie,$j.ui.accordion,$j.ui.slider,$j.ui.datepicker"></script>
 6+ <script type="text/javascript" src="../jsScriptLoader.php?urid=52884&class=mv_embed,window.jQuery,mvBaseUploadInterface,mvFirefogg,mvAdvFirefogg,$j.ui,$j.ui.progressbar,$j.ui.dialog,$j.cookie,$j.ui.accordion,$j.ui.slider,$j.ui.datepicker"></script>
77 <style type="text/css" media="all">body {
88 margin: 0;
99 padding: 0;
Index: branches/new-upload/phase3/js2/mwEmbed/libAddMedia/mvAdvFirefogg.js
@@ -310,7 +310,7 @@
311311 var icon = (target=='target_btn_save_local_file')?'ui-icon-video':'ui-icon-folder-open';
312312 return '<a class="ui-state-default ui-corner-all ui-icon_link '+
313313 target +'" href="#"><span class="ui-icon ' + icon + '"/>' +
314 - gM( 'fogg-' + target.substring(11)) +
 314+ gM( 'fogg-' + target.substring(11) ) +
315315 '</a>';
316316 }else if( target=='target_use_latest_fox' ||
317317 target=='target_please_install' ||
@@ -320,7 +320,7 @@
321321 '<p><span style="float: left; margin-right: 0.3em;" class="ui-icon ui-icon-alert"/>'+
322322 gM( 'fogg-' + target.substring(7)) +'</p>'+
323323 '</div>';
324 - }else if(target=='target_input_file_name'){
 324+ }else if( target == 'target_input_file_name'){
325325 return '<input style="" class="text ui-widget-content ui-corner-all ' + target + '" '+
326326 'type="text" value="' + gM( 'fogg-' + target.substring(11)) + '"/> ';
327327 }else{
@@ -415,10 +415,10 @@
416416 js_log('tw:' + $j(this.selector).width() +
417417 'ssf:' + $j(this.target_btn_select_new_file).width() +
418418 'sf:' + $j(this.target_btn_save_local_file).width() );
419 - $j(this.target_input_file_name).width(
420 - $j(this.selector).width() - ( $j(this.target_btn_select_new_file).width() +
421 - $j(this.target_btn_save_local_file).width() + 50 )
422 - )
 419+
 420+ var tiwidth = $j(this.selector).width() - ( $j(this.target_btn_select_new_file).width() +
 421+ $j(this.target_btn_save_local_file).width() + 80 );
 422+ $j(this.target_input_file_name).width( tiwidth );
423423
424424 //special preset action:
425425 $j(this.selector + ' ._preset_select').change(function(){

Status & tagging log