r52877 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52876‎ | r52877 | r52878 >
Date:00:22, 8 July 2009
Author:tparscal
Status:ok
Tags:
Comment:
Resolved problem with classes being defined twice.
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -384,7 +384,9 @@
385385 if ( $nav[$section][$key]['class'] ) {
386386 $nav[$section][$key]['attributes'] .=
387387 ' class="' . htmlspecialchars( $link['class'] ) . '"';
 388+ unset( $nav[$section][$key]['class'] );
388389 }
 390+
389391 // We don't want to give the watch tab an accesskey if the page is
390392 // being edited, because that conflicts with the accesskey on the
391393 // watch checkbox. We also don't want to give the edit tab an
@@ -587,7 +589,7 @@
588590 <div class="menu">
589591 <ul <?php $this->html('userlangattributes') ?>>
590592 <?php foreach ($this->data['variant_urls'] as $key => $link ): ?>
591 - <li<?php echo $link['attributes'] ?><?php if(!empty($link['class'])): ?> class="<?php echo htmlspecialchars($link['class']) ?>"<?php endif; ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><?php echo htmlspecialchars( $link['text'] ) ?></a></li>
 593+ <li<?php echo $link['attributes'] ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><?php echo htmlspecialchars( $link['text'] ) ?></a></li>
592594 <?php endforeach; ?>
593595 </ul>
594596 </div>
@@ -602,7 +604,7 @@
603605 <h5><?php $this->msg('views') ?></h5>
604606 <ul <?php $this->html('userlangattributes') ?>>
605607 <?php foreach ($this->data['view_urls'] as $key => $link ): ?>
606 - <li<?php echo $link['attributes'] ?><?php if(!empty($link['class'])): ?> class="<?php echo htmlspecialchars($link['class']) ?>"<?php endif; ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><span><?php echo htmlspecialchars( $link['text'] ) ?></span></a></li>
 608+ <li<?php echo $link['attributes'] ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><span><?php echo htmlspecialchars( $link['text'] ) ?></span></a></li>
607609 <?php endforeach; ?>
608610 </ul>
609611 </div>
@@ -615,7 +617,7 @@
616618 <div class="menu">
617619 <ul <?php $this->html('userlangattributes') ?>>
618620 <?php foreach ($this->data['action_urls'] as $key => $link ): ?>
619 - <li<?php echo $link['attributes'] ?><?php if(!empty($link['class'])): ?> class="<?php echo htmlspecialchars($link['class']) ?>"<?php endif; ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><?php echo htmlspecialchars( $link['text'] ) ?></a></li>
 621+ <li<?php echo $link['attributes'] ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><?php echo htmlspecialchars( $link['text'] ) ?></a></li>
620622 <?php endforeach; ?>
621623 </ul>
622624 </div>

Status & tagging log