r52876 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52875‎ | r52876 | r52877 >
Date:23:49, 7 July 2009
Author:tparscal
Status:ok
Tags:
Comment:
Fixed the way loading icon is positioned.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.css
@@ -45,7 +45,8 @@
4646 float: right;
4747 }
4848 div#edittoolbar div.sections div.loading {
49 - padding: 10px;
 49+ padding-top: 0.5em;
 50+ padding-bottom: 0.5em;
5051 }
5152 div#edittoolbar div.sections div div.progress {
5253 display: none;
@@ -56,13 +57,16 @@
5758 background-position: left center;
5859 background-repeat: no-repeat;
5960 padding-left: 32px;
 61+ margin-left: 1em;
6062 float: left;
6163 color: #666666;
6264 }
63 -div#edittoolbar div.sections div.loading div.progress {
 65+body.rtl div#edittoolbar div.sections div.loading div.progress {
6466 background-position: right center;
6567 padding-left: 0;
6668 padding-right: 32px;
 69+ margin-left: 0;
 70+ margin-right: 1em;
6771 float: right;
6872 }
6973 /* Toolbar Groups and Tabs */
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js
@@ -88,7 +88,6 @@
8989 $(this).data( 'sectionCookie' ),
9090 show ? $(this).data( 'sectionDiv' ).attr( 'id' ) : null
9191 );
92 - /*$(this).data( 'textbox' ).focus();*/
9392 return false;
9493 })
9594 )

Follow-up revisions

RevisionCommit summaryAuthorDate
r53410Merging UI fixes from trunk; second batch from http://www.mediawiki.org/wiki/......brion18:05, 17 July 2009

Status & tagging log