r52873 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52872‎ | r52873 | r52874 >
Date:23:25, 7 July 2009
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Tweaked logic to be more like original version, however I'm still unsure the logic was any good to start with.
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -904,14 +904,19 @@
905905 // Exits, since only reviewable pages need these tabs
906906 return true;
907907 }
 908+ /*
 909+ * FIXME: IS THIS LOGIC CORRECT? IT DOES NOT MAKES SENSE THAT WE ONLY
 910+ * PROVICE A STABLIZE TAB FOR PEOPLE WHTHOUT PROTECTION RIGHTS BUT WITH
 911+ * AT LEAST ONE TAB AS SEEN HERE...
 912+ */
908913 // Checks if...
909914 if (
910 - // This page is a talk page
 915+ // This page is not a talk page
911916 !$skin->mTitle->isTalkPage() &&
912917 // User is allowed to stablize pages
913918 $wgUser->isAllowed( 'stablesettings' ) &&
914919 // Actions is an array
915 - is_array( $actions ) &&
 920+ count( $actions ) &&
916921 // A protect tab does not exist
917922 !isset( $actions['protect'] ) &&
918923 // An unprtect tab does not exist

Comments

#Comment by Tim Starling (talk | contribs)   07:55, 10 July 2009

Fixed by Aaron in r52880.

Status & tagging log