r52855 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52854‎ | r52855 | r52856 >
Date:20:24, 7 July 2009
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Added position:relative to #bodyContent to allow absolutes to be relative to it, rather than #content. Also, changed #actions to #p-cactions to be compatible with some javascript routines.
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -610,7 +610,7 @@
611611 <!-- /views -->
612612 <!-- actions -->
613613 <?php if ( count( $this->data['action_urls'] ) > 0 ): ?>
614 - <div id="actions" class="vectorMenu">
 614+ <div id="p-cactions" class="vectorMenu">
615615 <h5><span><?php $this->msg('actions') ?></span><a href="#">&nbsp;</a></h5>
616616 <div class="menu">
617617 <ul <?php $this->html('userlangattributes') ?>>
Index: trunk/phase3/skins/vector/main-ltr.css
@@ -733,7 +733,7 @@
734734 #siteNotice {
735735 text-align: center;
736736 font-size: 95%;
737 - padding-top: 0.9em;
 737+ margin-bottom: 0.9em;
738738 }
739739 #siteNotice p {
740740 margin: 0;
@@ -889,3 +889,7 @@
890890 padding: 5px;
891891 font-size: 95%;
892892 }
 893+
 894+div#bodyContent {
 895+ position: relative;
 896+}
\ No newline at end of file
Index: trunk/phase3/skins/vector/main-rtl.css
@@ -746,7 +746,7 @@
747747 #siteNotice {
748748 text-align: center;
749749 font-size: 95%;
750 - padding-top: 0.9em;
 750+ margin-bottom: 0.9em;
751751 }
752752 #siteNotice p {
753753 margin: 0;
@@ -901,3 +901,7 @@
902902 padding: 5px;
903903 font-size: 95%;
904904 }
 905+
 906+div#bodyContent {
 907+ position: relative;
 908+}
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r53410Merging UI fixes from trunk; second batch from http://www.mediawiki.org/wiki/......brion18:05, 17 July 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   22:20, 14 September 2011

The position: relative seems to trigger bug 27231 on IE 7 (weird display corruption when popping in a js-message box such as the watch/unwatch thingy).

Doesn't happen on IE 6 or on IE 8 and later, however.

Status & tagging log