r52817 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52816‎ | r52817 | r52818 >
Date:23:46, 6 July 2009
Author:tparscal
Status:ok
Tags:
Comment:
Changed logo XML ID
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -693,12 +693,12 @@
694694 </div>
695695 <!-- /foot -->
696696 <!-- logo -->
697 - <div id="logo">
 697+ <div id="p-logo">
698698 <a style="background-image: url(<?php $this->text('logopath') ?>);" href="<?php echo htmlspecialchars( $this->data['nav_urls']['mainpage']['href'] ) ?>" <?php echo $this->skin->tooltipAndAccesskey('p-logo') ?>></a>
699699 </div>
700700 <!-- /logo -->
701701 <!-- fixalpha -->
702 - <script type="<?php $this->text('jsmimetype') ?>"> if (window.isMSIE55) fixalpha( 'logo' ); </script>
 702+ <script type="<?php $this->text('jsmimetype') ?>"> if (window.isMSIE55) fixalpha( 'p-logo' ); </script>
703703 <!-- /fixalpha -->
704704 <?php $this->html( 'bottomscripts' ); /* JS call to runBodyOnloadHook */ ?>
705705 <?php $this->html( 'reporttime' ) ?>
Index: trunk/phase3/skins/vector/main-ltr.css
@@ -305,14 +305,14 @@
306306 line-height: 2em;
307307 }
308308 /* Logo */
309 -div#logo {
 309+div#p-logo {
310310 position: absolute;
311311 top: 0;
312312 left: 0;
313313 height: 12em;
314314 width: 12em;
315315 }
316 -div#logo a {
 316+div#p-logo a {
317317 display: block;
318318 width: 12em;
319319 height: 12em;
Index: trunk/phase3/skins/vector/main-rtl.css
@@ -319,14 +319,14 @@
320320 line-height: 2em;
321321 }
322322 /* Logo */
323 -div#logo {
 323+div#p-logo {
324324 position: absolute;
325325 top: 0;
326326 right: 0;
327327 height: 12em;
328328 width: 12em;
329329 }
330 -div#logo a {
 330+div#p-logo a {
331331 display: block;
332332 width: 12em;
333333 height: 12em;

Follow-up revisions

RevisionCommit summaryAuthorDate
r53410Merging UI fixes from trunk; second batch from http://www.mediawiki.org/wiki/......brion18:05, 17 July 2009

Status & tagging log