r52816 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52815‎ | r52816 | r52817 >
Date:23:44, 6 July 2009
Author:tparscal
Status:ok
Tags:
Comment:
Changed XML IDs to be compatible with monobook things, and now tabs and menus are class driven rather than ID
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -572,7 +572,7 @@
573573 <!-- /personal -->
574574 <div id="left-navigation">
575575 <!-- namespaces -->
576 - <div id="namespaces">
 576+ <div id="namespaces" class="vectorTabs">
577577 <h5><?php $this->msg('namespaces') ?></h5>
578578 <ul <?php $this->html('userlangattributes') ?>>
579579 <?php foreach ($this->data['namespace_urls'] as $key => $link ): ?>
@@ -583,7 +583,7 @@
584584 <!-- /namespaces -->
585585 <!-- variants -->
586586 <?php if ( count( $this->data['variant_urls'] ) > 0 ): ?>
587 - <div id="variants">
 587+ <div id="variants" class="vectorMenu">
588588 <h5><span><?php $this->msg('variants') ?></span><a href="#">&nbsp;</a></h5>
589589 <div class="menu">
590590 <ul <?php $this->html('userlangattributes') ?>>
@@ -599,7 +599,7 @@
600600 <div id="right-navigation">
601601 <!-- views -->
602602 <?php if ( count( $this->data['view_urls'] ) > 0 ): ?>
603 - <div id="views">
 603+ <div id="views" class="vectorTabs">
604604 <h5><?php $this->msg('views') ?></h5>
605605 <ul <?php $this->html('userlangattributes') ?>>
606606 <?php foreach ($this->data['view_urls'] as $key => $link ): ?>
@@ -611,7 +611,7 @@
612612 <!-- /views -->
613613 <!-- actions -->
614614 <?php if ( count( $this->data['action_urls'] ) > 0 ): ?>
615 - <div id="actions">
 615+ <div id="actions" class="vectorMenu">
616616 <h5><span><?php $this->msg('actions') ?></span><a href="#">&nbsp;</a></h5>
617617 <div class="menu">
618618 <ul <?php $this->html('userlangattributes') ?>>
@@ -624,7 +624,7 @@
625625 <?php endif; ?>
626626 <!-- /actions -->
627627 <!-- search -->
628 - <div id="search">
 628+ <div id="p-search">
629629 <h5 <?php $this->html('userlangattributes') ?>><label for="searchInput"><?php $this->msg( 'search' ) ?></label></h5>
630630 <form action="<?php $this->text( 'wgScript' ) ?>" id="searchform">
631631 <input type='hidden' name="title" value="<?php $this->text( 'searchtitle' ) ?>"/>
Index: trunk/phase3/skins/vector/main-ltr.css
@@ -41,12 +41,6 @@
4242 right: 0;
4343 width: 100%;
4444 }
45 -div#head ul,
46 -div#head li {
47 - list-style: none;
48 - margin: 0;
49 - padding: 0;
50 -}
5145 div#head h5 {
5246 margin: 0;
5347 padding: 0;
@@ -60,6 +54,11 @@
6155 div#p-personal h5 {
6256 display: none;
6357 }
 58+ div#p-personal ul {
 59+ list-style: none;
 60+ margin: 0;
 61+ padding: 0;
 62+ }
6463 div#p-personal li {
6564 float: left;
6665 margin-left: 0.75em;
@@ -77,49 +76,45 @@
7877 margin-top: 3em;
7978 }
8079 /* Navigation Labels */
81 - div#namespaces h5,
82 - div#variants h5 span,
83 - div#views h5,
84 - div#actions h5 span,
85 - div#search h5 {
 80+ div.vectorTabs h5,
 81+ div.vectorMenu h5 span {
8682 display: none;
8783 }
8884 /* Namespaces and Views */
89 - div#namespaces,
90 - div#views {
 85+ div.vectorTabs {
9186 float: left;
9287 background-image: url(images/tab-break.png);
9388 background-position: bottom left;
9489 background-repeat: no-repeat;
9590 padding-left: 1px;
9691 }
97 - div#namespaces ul,
98 - div#views ul {
 92+ div.vectorTabs ul {
9993 float: left;
10094 height: 100%;
 95+ list-style: none;
 96+ margin: 0;
 97+ padding: 0;
10198 }
10299 /* OVERRIDDEN BY COMPLIANT BROWSERS */
103 - div#namespaces ul li,
104 - div#views ul li {
 100+ div.vectorTabs ul li {
105101 display: inline-block;
106102 float: left;
107103 height: 100%;
 104+ margin: 0;
 105+ padding: 0;
108106 background-image: url(images/tab-normal-fade.png);
109107 background-position: bottom left;
110108 background-repeat: repeat-x;
111109 }
112110 /* IGNORED BY IE6 */
113 - div#namespaces ul > li,
114 - div#views ul > li {
 111+ div.vectorTabs ul > li {
115112 display: block;
116113 }
117 - div#namespaces li.selected,
118 - div#views li.selected {
 114+ div.vectorTabs li.selected {
119115 background-image: url(images/tab-current-fade.png);
120116 }
121117 /* OVERRIDDEN BY COMPLIANT BROWSERS */
122 - div#namespaces li a,
123 - div#views li a {
 118+ div.vectorTabs li a {
124119 display: inline-block;
125120 height: 3em;
126121 padding-left: 0.5em;
@@ -129,49 +124,43 @@
130125 background-repeat: no-repeat;
131126 }
132127 /* IGNORED BY IE6 */
133 - div#namespaces li > a,
134 - div#views li > a {
 128+ div.vectorTabs li > a {
135129 display: block;
136130 }
137131 /* OVERRIDDEN BY COMPLIANT BROWSERS */
138 - div#namespaces a span,
139 - div#views a span {
 132+ div.vectorTabs a span {
140133 color: #0645ad;
141134 display: inline-block;
142135 padding-top: 1.25em;
143136 cursor: pointer;
144137 }
145138 /* IGNORED BY IE6 */
146 - div#namespaces a > span,
147 - div#views a > span {
 139+ div.vectorTabs a > span {
148140 float: left;
149141 display: block;
150142 }
151 - div#namespaces li.selected a span,
152 - div#views li.selected a:visited span {
 143+ div.vectorTabs li.selected a span,
 144+ div.vectorTabs li.selected a:visited span {
153145 color: #333333;
154146 cursor: default;
155147 text-decoration: none;
156148 }
157 - div#namespaces li.new a span,
158 - div#namespaces li.new a:visited span{
 149+ div.vectorTabs li.new a span,
 150+ div.vectorTabs li.new a:visited span {
159151 color: #a55858;
160152 }
161153 /* Variants and Actions */
162 - div#variants,
163 - div#actions {
 154+ div.vectorMenu {
164155 float: left;
165156 background-image: url(images/arrow-down-icon.png);
166157 background-position: center center;
167158 background-repeat: no-repeat;
168159 }
169 - div#variants h5,
170 - div#actions h5 {
 160+ div.vectorMenu h5 {
171161 float: left;
172162 }
173163 /* OVERRIDDEN BY COMPLIANT BROWSERS */
174 - div#variants h5 a,
175 - div#actions h5 a {
 164+ div.vectorMenu h5 a {
176165 display: inline-block;
177166 width: 24px;
178167 height: 3em;
@@ -181,47 +170,49 @@
182171 background-repeat: no-repeat;
183172 }
184173 /* IGNORED BY IE6 */
185 - div#variants h5 > a,
186 - div#actions h5 > a {
 174+ div.vectorMenu h5 > a {
187175 display: block;
188176 }
189 - div#variants div.menu,
190 - div#actions div.menu {
 177+ div.vectorMenu div.menu {
191178 display: none;
192179 clear: both;
193180 }
194 - div#variants:hover div.menu,
195 - div#actions:hover div.menu {
 181+ div.vectorMenu:hover div.menu {
196182 display: block;
197183 }
198 - div#variants ul,
199 - div#actions ul {
 184+ div.vectorMenu ul {
200185 position: absolute;
201186 background-color: white;
202187 border: solid 1px silver;
203188 border-top-width: 0;
 189+ list-style: none;
204190 padding: 0;
205191 margin: 0;
206192 margin-left: -1px;
207193 }
 194+ div.vectorMenu li {
 195+ padding: 0;
 196+ margin: 0;
 197+ }
208198 /* OVERRIDDEN BY COMPLIANT BROWSERS */
209 - div#variants:hover li a,
210 - div#actions li a {
 199+ div.vectorMenu li a {
211200 display: inline-block;
212201 padding: 0.5em;
213202 }
214203 /* IGNORED BY IE6 */
215 - div#variants:hover li > a,
216 - div#actions li > a {
 204+ div.vectorMenu li > a {
217205 display: block;
218206 }
219207 /* Search */
220 - div#search {
 208+ div#p-search h5 {
 209+ display: none;
 210+ }
 211+ div#p-search {
221212 float: left;
222213 margin-right: 0.75em;
223214 }
224 - div#search form,
225 - div#search input {
 215+ div#p-search form,
 216+ div#p-search input {
226217 float: left;
227218 margin-top: 0.4em;
228219 margin-left: 0.25em;
Index: trunk/phase3/skins/vector/main-rtl.css
@@ -54,12 +54,6 @@
5555 left: 0;
5656 width: 100%;
5757 }
58 -div#head ul,
59 -div#head li {
60 - list-style: none;
61 - margin: 0;
62 - padding: 0;
63 -}
6458 div#head h5 {
6559 margin: 0;
6660 padding: 0;
@@ -73,6 +67,11 @@
7468 div#p-personal h5 {
7569 display: none;
7670 }
 71+ div#p-personal ul {
 72+ list-style: none;
 73+ margin: 0;
 74+ padding: 0;
 75+ }
7776 div#p-personal li {
7877 float: right;
7978 margin-right: 0.75em;
@@ -90,49 +89,45 @@
9190 margin-top: 3em;
9291 }
9392 /* Navigation Labels */
94 - div#namespaces h5,
95 - div#variants h5 span,
96 - div#views h5,
97 - div#actions h5 span,
98 - div#search h5 {
 93+ div.vectorTabs h5,
 94+ div.vectorMenu h5 span {
9995 display: none;
10096 }
10197 /* Namespaces and Views */
102 - div#namespaces,
103 - div#views {
 98+ div.vectorTabs {
10499 float: right;
105100 background-image: url(images/tab-break.png);
106101 background-position: bottom right;
107102 background-repeat: no-repeat;
108103 padding-right: 1px;
109104 }
110 - div#namespaces ul,
111 - div#views ul {
 105+ div.vectorTabs ul {
112106 float: right;
113107 height: 100%;
 108+ list-style: none;
 109+ margin: 0;
 110+ padding: 0;
114111 }
115112 /* OVERRIDDEN BY COMPLIANT BROWSERS */
116 - div#namespaces ul li,
117 - div#views ul li {
 113+ div.vectorTabs ul li {
118114 display: inline-block;
119115 float: right;
120116 height: 100%;
 117+ margin: 0;
 118+ padding: 0;
121119 background-image: url(images/tab-normal-fade.png);
122120 background-position: bottom right;
123121 background-repeat: repeat-x;
124122 }
125123 /* IGNORED BY IE6 */
126 - div#namespaces ul > li,
127 - div#views ul > li {
 124+ div.vectorTabs ul > li {
128125 display: block;
129126 }
130 - div#namespaces li.selected,
131 - div#views li.selected {
 127+ div.vectorTabs li.selected {
132128 background-image: url(images/tab-current-fade.png);
133129 }
134130 /* OVERRIDDEN BY COMPLIANT BROWSERS */
135 - div#namespaces li a,
136 - div#views li a {
 131+ div.vectorTabs li a {
137132 display: inline-block;
138133 height: 3em;
139134 padding-right: 0.5em;
@@ -142,49 +137,44 @@
143138 background-repeat: no-repeat;
144139 }
145140 /* IGNORED BY IE6 */
146 - div#namespaces li > a,
147 - div#views li > a {
 141+ div.vectorTabs li > a {
148142 display: block;
149143 }
150144 /* OVERRIDDEN BY COMPLIANT BROWSERS */
151 - div#namespaces a span,
152 - div#views a span {
 145+ div.vectorTabs a span {
153146 color: #0645ad;
154147 display: inline-block;
155148 padding-top: 1.25em;
156149 cursor: pointer;
157150 }
158151 /* IGNORED BY IE6 */
159 - div#namespaces a > span,
160 - div#views a > span {
 152+ div.vectorTabs a > span {
161153 float: right;
162154 display: block;
163155 }
164 - div#namespaces li.selected a span,
165 - div#views li.selected a:visited span {
 156+ div.vectorTabs li.selected a span,
 157+ div.vectorTabs li.selected a:visited span {
166158 color: #333333;
167159 cursor: default;
168160 text-decoration: none;
169161 }
170 - div#namespaces li.new a span,
171 - div#namespaces li.new a:visited span{
 162+ div.vectorTabs li.new a span,
 163+ div.vectorTabs li.new a:visited span{
172164 color: #a55858;
173165 }
 166+
174167 /* Variants and Actions */
175 - div#variants,
176 - div#actions {
 168+ div.vectorMenu {
177169 float: right;
178170 background-image: url(images/arrow-down-icon.png);
179171 background-position: center center;
180172 background-repeat: no-repeat;
181173 }
182 - div#variants h5,
183 - div#actions h5 {
 174+ div.vectorMenu h5 {
184175 float: right;
185176 }
186177 /* OVERRIDDEN BY COMPLIANT BROWSERS */
187 - div#variants h5 a,
188 - div#actions h5 a {
 178+ div.vectorMenu h5 a {
189179 display: inline-block;
190180 width: 24px;
191181 height: 3em;
@@ -194,47 +184,49 @@
195185 background-repeat: no-repeat;
196186 }
197187 /* IGNORED BY IE6 */
198 - div#variants h5 > a,
199 - div#actions h5 > a {
 188+ div.vectorMenu h5 > a {
200189 display: block;
201190 }
202 - div#variants div.menu,
203 - div#actions div.menu {
 191+ div.vectorMenu div.menu {
204192 display: none;
205193 clear: both;
206194 }
207 - div#variants:hover div.menu,
208 - div#actions:hover div.menu {
 195+ div.vectorMenu:hover div.menu {
209196 display: block;
210197 }
211 - div#variants ul,
212 - div#actions ul {
 198+ div.vectorMenu ul {
213199 position: absolute;
214200 background-color: white;
215201 border: solid 1px silver;
216202 border-top-width: 0;
 203+ list-style: none;
217204 padding: 0;
218205 margin: 0;
219206 margin-right: -1px;
220207 }
 208+ div.vectorMenu li {
 209+ padding: 0;
 210+ margin: 0;
 211+ }
221212 /* OVERRIDDEN BY COMPLIANT BROWSERS */
222 - div#variants:hover li a,
223 - div#actions li a {
 213+ div.vectorMenu li a {
224214 display: inline-block;
225215 padding: 0.5em;
226216 }
227217 /* IGNORED BY IE6 */
228 - div#variants:hover li > a,
229 - div#actions li > a {
 218+ div.vectorMenu li > a {
230219 display: block;
231220 }
232221 /* Search */
233 - div#search {
 222+ div#p-search h5 {
 223+ display: none;
 224+ }
 225+ div#p-search {
234226 float: right;
235227 margin-left: 0.75em;
236228 }
237 - div#search form,
238 - div#search input {
 229+ div#p-search form,
 230+ div#p-search input {
239231 float: right;
240232 margin-top: 0.4em;
241233 margin-right: 0.25em;

Follow-up revisions

RevisionCommit summaryAuthorDate
r53410Merging UI fixes from trunk; second batch from http://www.mediawiki.org/wiki/......brion18:05, 17 July 2009

Status & tagging log