r52775 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52774‎ | r52775 | r52776 >
Date:13:07, 5 July 2009
Author:thomasv
Status:deferred
Tags:
Comment:
minor: always add header and footer, even if they are empty
Modified paths:
  • /trunk/extensions/ProofreadPage/proofread.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/proofread.js
@@ -776,15 +776,11 @@
777777 var form = document.getElementById("editform");
778778 var header = form.elements["headerTextbox"];
779779 var footer = form.elements["footerTextbox"];
780 - //if( ( self.proofreadpage_quality == 0 ) && ( form.elements["wpTextbox1"].value != "" ) ) {
781 - // self.proofreadpage_quality = 1;
782 - // form.elements["wpSummary"].value="/* " + proofreadPageMessageQuality1 + " */ ";
783 - //}
784780 if(header){
785781 var h = header.value.replace(/(\s*(\r?\n|\r))+$/, '');
786 - if(h) h = "<noinclude><pagequality level=\""+self.proofreadpage_quality+"\" user=\""+self.proofreadpage_username+"\" />"+h+"\n\n\n</noinclude>";
 782+ h = "<noinclude><pagequality level=\""+self.proofreadpage_quality+"\" user=\""+self.proofreadpage_username+"\" />"+h+"\n\n\n</noinclude>";
787783 var f = footer.value;
788 - if(f) f = "<noinclude>\n"+f+"</noinclude>";
 784+ f = "<noinclude>\n"+f+"</noinclude>";
789785 var ph = header.parentNode;
790786 ph.removeChild(header);
791787 var pf = footer.parentNode;

Status & tagging log