r52755 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52754‎ | r52755 | r52756 >
Date:21:12, 3 July 2009
Author:robin
Status:deferred
Tags:
Comment:
Add $wgDefaultUserOptions to fix error on Special:Preferences
Modified paths:
  • /trunk/extensions/WikimediaIncubator/IncubatorTest.php (modified) (history)
  • /trunk/extensions/WikimediaIncubator/WikimediaIncubator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikimediaIncubator/WikimediaIncubator.php
@@ -10,7 +10,7 @@
1111 'path' => __FILE__,
1212 'name' => 'Wikimedia Incubator',
1313 'author' => 'SPQRobin',
14 - 'version' => '2.3.1',
 14+ 'version' => '2.3.2',
1515 'url' => 'http://www.mediawiki.org/wiki/Extension:WikimediaIncubator',
1616 'description' => 'Test wiki features for Wikimedia Incubator',
1717 'descriptionmsg' => 'wminc-desc',
Index: trunk/extensions/WikimediaIncubator/IncubatorTest.php
@@ -6,7 +6,7 @@
77 class IncubatorTest
88 {
99 static function onGetPreferences( $user, &$preferences ) {
10 - global $wmincPref, $wmincPrefProject, $wmincPrefNone;
 10+ global $wmincPref, $wmincPrefProject, $wmincPrefNone, $wgDefaultUserOptions;
1111
1212 $preferences['language']['help-message'] = 'wminc-prefinfo-language';
1313
@@ -30,6 +30,8 @@
3131 'validation-callback' => array( 'IncubatorTest', 'CodeValidation' ),
3232 );
3333
 34+ $wgDefaultUserOptions[$wmincPref . '-project'] = 'none';
 35+
3436 $preferences = wfArrayInsertAfter( $preferences, $prefinsert, 'language' );
3537
3638 return true;

Status & tagging log