r52742 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r52741‎ | r52742 | r52743 >
Date:14:06, 3 July 2009
Author:werdna
Status:ok
Tags:
Comment:
Fix bug in HTMLForm system where "Other" option for timezone was shown twice, reported as bug 19321
Modified paths:
  • /trunk/phase3/includes/HTMLForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HTMLForm.php
——@@ -630,7 +630,7 @@
631631 static $jsAdded = false;
632632
633633 function __construct( $params ) {
634 - if( !array_key_exists( 'other', $params['options'] ) ) {
 634+ if( !in_array( 'other', $params['options'] ) ) {
635635 $params['options'][wfMsg( 'htmlform-selectorother-other' )] = 'other';
636636 }
637637

Status & tagging log