r52741 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52740‎ | r52741 | r52742 >
Date:14:03, 3 July 2009
Author:werdna
Status:ok
Tags:
Comment:
Move addition of prefs.js down, to avoid errors when you can't view the form as in bug 19307
Modified paths:
  • /trunk/phase3/includes/specials/SpecialPreferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialPreferences.php
@@ -10,9 +10,6 @@
1111
1212 $this->setHeaders();
1313 $this->outputHeader();
14 -
15 - $wgOut->addScriptFile( 'prefs.js' );
16 -
1714 $wgOut->disallowUserJs(); # Prevent hijacked user scripts from sniffing passwords etc.
1815
1916 if ( $wgUser->isAnon() ) {
@@ -28,6 +25,8 @@
2926 $this->showResetForm();
3027 return;
3128 }
 29+
 30+ $wgOut->addScriptFile( 'prefs.js' );
3231
3332 if ( $wgRequest->getCheck( 'success' ) ) {
3433 $wgOut->wrapWikiMsg(

Status & tagging log