r52664 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r52663‎ \| r52664 \| r52665 >
Date:	23:32, 1 July 2009
Author:	rainman
Status:	ok (Comments)
Tags:
Comment:	Use accessor here since someone added it to avoid warnings.
Modified paths:	/trunk/extensions/MWSearch/MWSearch_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MWSearch/MWSearch_body.php
—	—	@@ -90,7 +90,7 @@
91	91
92	92	global $wgCanonicalNamespaceNames, $wgNamespaceAliases;
93	93	$nsNamesRaw = array_merge($wgContLang->getNamespaces(), $wgCanonicalNamespaceNames,
94		~~- array_keys( array_merge($wgNamespaceAliases, $wgContLang->namespaceAliases) ) );~~
	94	+ array_keys( array_merge($wgNamespaceAliases, $wgContLang->getNamespaceAliases()) ) );
95	95
96	96	# add all namespace names w/o spaces
97	97	$nsNames = array();

Comments

#Comment by Brion VIBBER (talk | contribs) 00:02, 2 July 2009

removed from live due to breakage since it relies on something that's not current

Status & tagging log

00:02, 2 July 2009 Brion VIBBER (talk | contribs) changed the tags for r52664 [removed: live]
00:02, 2 July 2009 Brion VIBBER (talk | contribs) changed the status of r52664 [removed: fixme added: ok]
00:00, 2 July 2009 Brion VIBBER (talk | contribs) changed the status of r52664 [removed: new added: fixme]
23:39, 1 July 2009 Brion VIBBER (talk | contribs) changed the tags for r52664 [added: live]