r52486 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52485‎ | r52486 | r52487 >
Date:10:40, 27 June 2009
Author:shinjiman
Status:reverted (Comments)
Tags:
Comment:
* (bug 14611) Added support showing the version of the diff/diff3 engine.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
@@ -100,7 +100,7 @@
101101 * @return wiki text showing the third party software versions (apache, php, mysql).
102102 */
103103 static function softwareInformation() {
104 - global $wgUseImageMagick, $wgImageMagickConvertCommand;
 104+ global $wgUseImageMagick, $wgImageMagickConvertCommand, $wgDiff3, $wgDiff;
105105 $dbr = wfGetDB( DB_SLAVE );
106106
107107 // Put the software in an array of form 'name' => 'version'. All messages should
@@ -111,6 +111,22 @@
112112 $software['[http://www.php.net/ PHP]'] = phpversion() . " (" . php_sapi_name() . ")";
113113 $software[$dbr->getSoftwareLink()] = $dbr->getServerVersion();
114114
 115+ // Version information for diff3
 116+ if ( file_exists( trim( $wgDiff3, '"' ) ) ) {
 117+ $swDiff3Info = self::execOutput( $wgDiff3 . ' -v' );
 118+ $swDiff3Line = explode("\n",$swDiff3Info ,2);
 119+ $swDiff3Ver = $swDiff3Line[0];
 120+ $software['[http://www.gnu.org/software/diffutils/diffutils.html diff3]'] = $swDiff3Ver;
 121+ }
 122+
 123+ // Version information for diff
 124+ if ( file_exists( trim( $wgDiff, '"' ) ) ) {
 125+ $swDiffInfo = self::execOutput( $wgDiff . ' -v' );
 126+ $swDiffLine = explode("\n",$swDiffInfo ,2);
 127+ $swDiffVer = $swDiffLine[0];
 128+ $software['[http://www.gnu.org/software/diffutils/diffutils.html diff]'] = $swDiffVer;
 129+ }
 130+
115131 // Look for ImageMagick's version, if did not found, try to find the GD library version
116132 if ( $wgUseImageMagick === true ) {
117133 if ( file_exists( trim( $wgImageMagickConvertCommand, '"' ) ) ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -92,7 +92,7 @@
9393 * Added a PHP port of CDB (constant database), for improved local caching when
9494 the DBA extension is not available.
9595 * (bug 14611) Added support showing the version of the image thumbnailing
96 - engine.
 96+ engine and diff/diff3 engine.
9797
9898 === Bug fixes in 1.16 ===
9999

Follow-up revisions

RevisionCommit summaryAuthorDate
r52516* (bug 14611) Added support showing the version of the SVG image thumbnailing...shinjiman16:25, 28 June 2009
r52525* (bug 14611) Added support showing the version of the Math rendering engine.shinjiman18:42, 28 June 2009
r52792* (bug 14611) Added support showing the version of the web server which it is...shinjiman12:08, 6 July 2009
r53398* (bug 14611) Add a global variable hook to show the extended software inform...shinjiman14:49, 17 July 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52476* (bug 14611) Added support showing the version of the image thumbnailing eng...shinjiman21:58, 26 June 2009

Comments

#Comment by Raymond (talk | contribs)   11:19, 27 June 2009

See at http://translatewiki.net/wiki/Special:Version

diff3 diff3 (GNU diffutils) 2.8.1 diff diff (GNU diffutils) 2.8.1


Bug or feature?

translatewiki.net has set:

$wgExternalDiffEngine = 'wikidiff2'; $wgDiff3 = "/usr/bin/diff3";

#Comment by Shinjiman (talk | contribs)   12:01, 27 June 2009

It's committed for the comment 0 on the bug 14611.

Special:Version should show all third party software which it depends on in Software table, typically graphical engine (eg. ImageMagick), diff engine etc...

Status & tagging log