r52477 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52476‎ | r52477 | r52478 >
Date:22:09, 26 June 2009
Author:demon
Status:resolved (Comments)
Tags:
Comment:
Cleanup for r52382: Call correct function and use tmestamp()
Modified paths:
  • /trunk/phase3/maintenance/updateSearchIndex.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/updateSearchIndex.inc
@@ -20,8 +20,8 @@
2121 output( "Updating searchindex between $start and $end\n" );
2222
2323 # Select entries from recentchanges which are on top and between the specified times
24 - $start = $dbw->strencode( $start );
25 - $end = $dbw->strencode( $end );
 24+ $start = $dbw->strencode( $dbw->timestamp( $start ) );
 25+ $end = $dbw->strencode( $dbw->timestamp( $end ) );
2626
2727 $page = $dbw->tableName( 'page' );
2828 $sql = "SELECT rc_cur_id,rc_type,rc_moved_to_ns,rc_moved_to_title FROM $recentchanges
@@ -90,7 +90,7 @@
9191 # Unlock and lock again
9292 # Since the lock is low-priority, queued reads will be able to complete
9393 function relockSearchindex( &$db ) {
94 - unlockSearchindex( $db );
 94+ lockSearchindex( $db );
9595 $db->unlockTables( 'updateSearchIndex.inc ' . __METHOD__ );
9696 }
9797

Follow-up revisions

RevisionCommit summaryAuthorDate
r53516Followup to r52477. Call unlock/lock in correct order :)demon02:18, 20 July 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52382* Move lock()/unlock() to DatabaseMysql, declare abstract...demon00:40, 25 June 2009

Comments

#Comment by OverlordQ (talk | contribs)   02:11, 20 July 2009

shouldn't relock call unlock/lock instead of lock/unlock?

Status & tagging log