r52457 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52456‎ | r52457 | r52458 >
Date:13:25, 26 June 2009
Author:ialex
Status:resolved
Tags:
Comment:
quick fix for r52382: fix errors in DatabasePostgres, lock() has incompatible signature lockTables(), unlockTables() (lockTables could have some implementation but not unlockTables since PostgreSQL has no command "UNLOCK TABLES")
Modified paths:
  • /trunk/phase3/includes/db/DatabasePostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabasePostgres.php
@@ -1389,7 +1389,7 @@
13901390
13911391 /* These are not used yet, but we know we don't want the default version */
13921392
1393 - public function lock( $lockName, $method ) {
 1393+ public function lock( $lockName, $method, $timeout = 5 ) {
13941394 return true;
13951395 }
13961396 public function unlock( $lockName, $method ) {
@@ -1403,4 +1403,9 @@
14041404 /** No-op */
14051405 public function setBigSelects( $value = true ) {}
14061406
 1407+ /** Todo: maybe implement this? */
 1408+ public function lockTables( $read, $write, $method ) {}
 1409+
 1410+ public function unlockTables( $method ) {}
 1411+
14071412 } // end DatabasePostgres class

Follow-up revisions

RevisionCommit summaryAuthorDate
r52466same as r52457 but for SQLiteialex15:38, 26 June 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52382* Move lock()/unlock() to DatabaseMysql, declare abstract...demon00:40, 25 June 2009

Status & tagging log