r52407 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52406‎ | r52407 | r52408 >
Date:19:07, 25 June 2009
Author:tparscal
Status:deferred
Tags:
Comment:
Added some fixes to make IE6 work
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.i18n.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/arrow-down.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/arrow-left.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/arrow-right.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/example-image.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/format-big.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/format-bold.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/format-italic.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/format-olist.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/format-small.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/format-subscript.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/format-superscript.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/format-ulist.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-file.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-gallery.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-ilink.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-newline.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-reference.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-signature.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-xlink.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24 (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/arrow-down.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/arrow-left.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/arrow-right.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-big.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-bold.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-italic.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-olist.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-small.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-subscript.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-superscript.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-ulist.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-file.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-gallery.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-ilink.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-newline.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-reference.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-signature.png (added) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-xlink.png (added) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/format-ulist.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-xlink.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/format-big.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/format-italic.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/format-small.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/arrow-down.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-reference.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-gallery.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-signature.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-newline.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/format-subscript.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/arrow-right.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/format-bold.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-olist.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-olist.png
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-file.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-file.png
___________________________________________________________________
Added: svn:mime-type
22 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/arrow-left.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/arrow-left.png
___________________________________________________________________
Added: svn:mime-type
33 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-ulist.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-ulist.png
___________________________________________________________________
Added: svn:mime-type
44 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-xlink.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-xlink.png
___________________________________________________________________
Added: svn:mime-type
55 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-big.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-big.png
___________________________________________________________________
Added: svn:mime-type
66 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-italic.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-italic.png
___________________________________________________________________
Added: svn:mime-type
77 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-small.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-small.png
___________________________________________________________________
Added: svn:mime-type
88 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/arrow-down.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/arrow-down.png
___________________________________________________________________
Added: svn:mime-type
99 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-reference.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-reference.png
___________________________________________________________________
Added: svn:mime-type
1010 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-gallery.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-gallery.png
___________________________________________________________________
Added: svn:mime-type
1111 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-signature.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-signature.png
___________________________________________________________________
Added: svn:mime-type
1212 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-newline.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-newline.png
___________________________________________________________________
Added: svn:mime-type
1313 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-subscript.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-subscript.png
___________________________________________________________________
Added: svn:mime-type
1414 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/arrow-right.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/arrow-right.png
___________________________________________________________________
Added: svn:mime-type
1515 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-bold.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-bold.png
___________________________________________________________________
Added: svn:mime-type
1616 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-ilink.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/insert-ilink.png
___________________________________________________________________
Added: svn:mime-type
1717 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-superscript.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/EditToolbar/images/png24/format-superscript.png
___________________________________________________________________
Added: svn:mime-type
1818 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-ilink.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/format-superscript.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/example-image.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/format-olist.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/insert-file.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/images/arrow-left.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.i18n.php
@@ -17,51 +17,49 @@
1818 'edittoolbar-preference' => 'Enable enhanced editing toolbar',
1919 'edittoolbar-loading' => 'Loading...',
2020 /* Main Section */
21 - 'edittoolbar-tool-format-bold' => 'Bold',
22 - 'edittoolbar-tool-format-bold-example' => 'Bold text',
23 - 'edittoolbar-tool-format-italic' => 'Italic',
24 - 'edittoolbar-tool-format-italic-example' => 'Italic text',
25 - 'edittoolbar-tool-insert-ilink' => 'Internal link',
26 - 'edittoolbar-tool-insert-ilink-example' => 'Link title',
27 - 'edittoolbar-tool-insert-xlink' => 'External link (remember http:// prefix)',
28 - 'edittoolbar-tool-insert-xlink-example' => 'http://www.example.com link title',
29 - 'edittoolbar-tool-insert-file' => 'Embedded file',
30 - 'edittoolbar-tool-insert-file-pre' => '$1File:', // FIXME: should be {{ns:file}}
31 - 'edittoolbar-tool-insert-file-example' => 'Example.jpg',
32 - 'edittoolbar-tool-insert-reference' => 'Reference',
33 - 'edittoolbar-tool-insert-reference-example' => 'Insert footnote text here',
34 - 'edittoolbar-tool-insert-signature' => 'Signature and timestamp',
35 - /* Formatting Section */
36 - 'edittoolbar-section-format' => 'Format',
37 - 'edittoolbar-tool-format-heading' => 'Heading',
38 - 'edittoolbar-tool-format-heading-1' => 'Level 1',
39 - 'edittoolbar-tool-format-heading-2' => 'Level 2',
40 - 'edittoolbar-tool-format-heading-3' => 'Level 3',
41 - 'edittoolbar-tool-format-heading-4' => 'Level 4',
42 - 'edittoolbar-tool-format-heading-5' => 'Level 5',
43 - 'edittoolbar-tool-format-heading-example' => 'Heading text',
44 - 'edittoolbar-group-format-list' => 'List',
45 - 'edittoolbar-tool-format-ulist' => 'Bulleted list',
46 - 'edittoolbar-tool-format-ulist-example' => 'Bulleted list item',
47 - 'edittoolbar-tool-format-olist' => 'Numbered list',
48 - 'edittoolbar-tool-format-olist-example' => 'Numbered list item',
49 - 'edittoolbar-group-format-size' => 'Size',
50 - 'edittoolbar-tool-format-big' => 'Big',
51 - 'edittoolbar-tool-format-big-example' => 'Big text',
52 - 'edittoolbar-tool-format-small' => 'Small',
53 - 'edittoolbar-tool-format-small-example' => 'Small text',
54 - 'edittoolbar-group-format-baseline' => 'Baseline',
55 - 'edittoolbar-tool-format-superscript' => 'Superscript',
56 - 'edittoolbar-tool-format-superscript-example' => 'Superscript text',
57 - 'edittoolbar-tool-format-subscript' => 'Subscript',
58 - 'edittoolbar-tool-format-subscript-example' => 'Subscript text',
59 - /* Insert Section */
60 - 'edittoolbar-section-insert' => 'Insert',
61 - 'edittoolbar-group-insert-media' => 'Media',
62 - 'edittoolbar-tool-insert-gallery' => 'Picture gallery',
63 - 'edittoolbar-tool-insert-gallery-example' => "File:Example.jpg|Caption1\nFile:Example.jpg|Caption2",
64 - 'edittoolbar-group-insert-whitespace' => 'Whitespace',
65 - 'edittoolbar-tool-insert-newline' => 'New line',
 21+ 'edittoolbar-tool-bold' => 'Bold',
 22+ 'edittoolbar-tool-bold-example' => 'Bold text',
 23+ 'edittoolbar-tool-italic' => 'Italic',
 24+ 'edittoolbar-tool-italic-example' => 'Italic text',
 25+ 'edittoolbar-tool-ilink' => 'Internal link',
 26+ 'edittoolbar-tool-ilink-example' => 'Link title',
 27+ 'edittoolbar-tool-xlink' => 'External link (remember http:// prefix)',
 28+ 'edittoolbar-tool-xlink-example' => 'http://www.example.com link title',
 29+ 'edittoolbar-tool-file' => 'Embedded file',
 30+ 'edittoolbar-tool-file-pre' => '$1File:', // FIXME: should be {{ns:file}}
 31+ 'edittoolbar-tool-file-example' => 'Example.jpg',
 32+ 'edittoolbar-tool-reference' => 'Reference',
 33+ 'edittoolbar-tool-reference-example' => 'Insert footnote text here',
 34+ 'edittoolbar-tool-signature' => 'Signature and timestamp',
 35+ /* Advanced Section */
 36+ 'edittoolbar-section-advanced' => 'Advanced',
 37+ 'edittoolbar-tool-heading' => 'Heading',
 38+ 'edittoolbar-tool-heading-1' => 'Level 1',
 39+ 'edittoolbar-tool-heading-2' => 'Level 2',
 40+ 'edittoolbar-tool-heading-3' => 'Level 3',
 41+ 'edittoolbar-tool-heading-4' => 'Level 4',
 42+ 'edittoolbar-tool-heading-5' => 'Level 5',
 43+ 'edittoolbar-tool-heading-example' => 'Heading text',
 44+ 'edittoolbar-group-list' => 'List',
 45+ 'edittoolbar-tool-ulist' => 'Bulleted list',
 46+ 'edittoolbar-tool-ulist-example' => 'Bulleted list item',
 47+ 'edittoolbar-tool-olist' => 'Numbered list',
 48+ 'edittoolbar-tool-olist-example' => 'Numbered list item',
 49+ 'edittoolbar-group-size' => 'Size',
 50+ 'edittoolbar-tool-big' => 'Big',
 51+ 'edittoolbar-tool-big-example' => 'Big text',
 52+ 'edittoolbar-tool-small' => 'Small',
 53+ 'edittoolbar-tool-small-example' => 'Small text',
 54+ 'edittoolbar-group-baseline' => 'Baseline',
 55+ 'edittoolbar-tool-superscript' => 'Superscript',
 56+ 'edittoolbar-tool-superscript-example' => 'Superscript text',
 57+ 'edittoolbar-tool-subscript' => 'Subscript',
 58+ 'edittoolbar-tool-subscript-example' => 'Subscript text',
 59+ 'edittoolbar-group-media' => 'Media',
 60+ 'edittoolbar-tool-gallery' => 'Picture gallery',
 61+ 'edittoolbar-tool-gallery-example' => "File:Example.jpg|Caption1\nFile:Example.jpg|Caption2",
 62+ 'edittoolbar-group-whitespace' => 'Whitespace',
 63+ 'edittoolbar-tool-newline' => 'New line',
6664 /* Special characters Section */
6765 'edittoolbar-section-characters' => 'Special characters',
6866 /* Help Section */
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.css
@@ -16,32 +16,14 @@
1717 margin: 0;
1818 }
1919 /* ... */
 20+
2021 div#edittoolbar {
2122 border: solid silver 1px;
2223 border-bottom-width: 0;
2324 background-color: #F3F3F3;
2425 }
25 -div#edittoolbar ul.tabs {
26 - list-style: none;
27 - margin: 0;
28 - padding: 0;
29 -}
30 -div#edittoolbar ul.tabs,
31 -div#edittoolbar div.group {
32 - float: left;
33 - height: 26px;
34 - margin: 3px;
35 - padding-left: 3px;
36 - border-left: solid 1px #DDDDDD;
37 -}
38 -body.rtl div#edittoolbar ul.tabs,
39 -body.rtl div#edittoolbar div.group {
40 - float: right;
41 - padding-left: 0;
42 - padding-right: 3px;
43 - border-left: none;
44 - border-right: solid 1px #DDDDDD;
45 -}
 26+
 27+/* Sections */
4628 div#edittoolbar div.sections {
4729 float: left;
4830 width: 100%;
@@ -80,6 +62,79 @@
8163 padding-right: 32px;
8264 float: right;
8365 }
 66+
 67+/* Toolbar Groups and Tabs */
 68+div#edittoolbar ul.tabs,
 69+div#edittoolbar div.group {
 70+ float: left;
 71+ height: 26px;
 72+ margin: 3px;
 73+ padding: 0;
 74+ padding-left: 3px;
 75+ border-left: solid 1px #DDDDDD;
 76+}
 77+div#edittoolbar div.first {
 78+ border-left: none;
 79+}
 80+body.rtl div#edittoolbar ul.tabs,
 81+body.rtl div#edittoolbar div.group {
 82+ float: right;
 83+ padding-left: 0;
 84+ padding-right: 3px;
 85+ border-left: none;
 86+ border-right: solid 1px #DDDDDD;
 87+}
 88+body.rtl div#edittoolbar div.first {
 89+ border-right: none;
 90+}
 91+
 92+/* Tabs */
 93+div#edittoolbar ul.tabs {
 94+ list-style: none;
 95+}
 96+div#edittoolbar ul.tabs li.tab {
 97+ display: inline-block;
 98+ float: left;
 99+ line-height: 26px;
 100+}
 101+body.rtl div#edittoolbar ul.tabs li.tab {
 102+ float: right;
 103+}
 104+div#edittoolbar ul.tabs li.tab a,
 105+div#edittoolbar ul.tabs li.tab a:visited {
 106+ display: inline-block;
 107+ float: left;
 108+ padding-left: 18px;
 109+ padding-right: 12px;
 110+ height: 26px;
 111+ cursor: pointer;
 112+ color: #0645ad;
 113+ background-image: url(images/arrow-right.png);
 114+ background-position: left center;
 115+ background-repeat: no-repeat;
 116+}
 117+body.rtl div#edittoolbar ul.tabs li.tab a,
 118+body.rtl div#edittoolbar ul.tabs li.tab a:visited {
 119+ float: right;
 120+ padding-left: 12px;
 121+ padding-right: 18px;
 122+ background-image: url(images/arrow-left.png);
 123+ background-position: right center;
 124+}
 125+div#edittoolbar ul.tabs li.tab a.current,
 126+div#edittoolbar ul.tabs li.tab a.current:visited {
 127+ color: #333333;
 128+ background-image: url(images/arrow-down.png);
 129+}
 130+body.rtl div#edittoolbar ul.tabs li.tab a.current,
 131+body.rtl div#edittoolbar ul.tabs li.tab a.current:visited {
 132+ background-image: url(images/arrow-down.png);
 133+}
 134+div#edittoolbar ul.tabs li.tab a.current:hover {
 135+ text-decoration: none;
 136+}
 137+
 138+/* Toolbar */
84139 div#edittoolbar div.group div.label {
85140 float: left;
86141 border: 0px;
@@ -96,7 +151,7 @@
97152 margin-left: 8px;
98153 margin-right: 5px;
99154 }
100 -div#edittoolbar div.group img.tool {
 155+div#edittoolbar div.group input.tool {
101156 float: left;
102157 border: 0px;
103158 height: 22px;
@@ -104,7 +159,7 @@
105160 padding: 2px;
106161 cursor: pointer;
107162 }
108 -body.rtl div#edittoolbar div.group img {
 163+body.rtl div#edittoolbar div.group input.tool {
109164 float: right;
110165 }
111166 div#edittoolbar div.group select {
@@ -117,6 +172,8 @@
118173 float: right;
119174 font-size: 0.9em;
120175 }
 176+
 177+/* Booklet */
121178 div#edittoolbar div.index {
122179 float: left;
123180 width: 20%;
@@ -141,9 +198,6 @@
142199 color: #333333;
143200 cursor: default;
144201 }
145 -div#edittoolbar div.index div:first-child {
146 - border-top: none;
147 -}
148202 div#edittoolbar div.pages {
149203 float: right;
150204 width: 80%;
@@ -157,9 +211,6 @@
158212 div#edittoolbar div.pages div.page {
159213 display: none;
160214 }
161 -div#edittoolbar div.pages div.page:first-child {
162 - display: block;
163 -}
164215 div#edittoolbar div.pages div.page table {
165216 padding-left: 5px;
166217 padding-right: 5px;
@@ -172,9 +223,6 @@
173224 color: black;
174225 border-top: solid 1px #EEEEEE;
175226 }
176 -div#edittoolbar div.pages div.page table tr:first-child td {
177 - border-top: solid 1px #DDDDDD;
178 -}
179227 div#edittoolbar div.pages div.page table th,
180228 div#edittoolbar div.pages div.page table td {
181229 text-align: left;
@@ -218,45 +266,4 @@
219267 background-color: white;
220268 text-decoration: none;
221269 border-color: #a8d7f9;
222 -}
223 -div#edittoolbar ul.tabs li.tab {
224 - display: inline-block;
225 - float: left;
226 - line-height: 26px;
227 -}
228 -body.rtl div#edittoolbar ul.tabs li.tab {
229 - float: right;
230 -}
231 -div#edittoolbar ul.tabs li.tab a,
232 -div#edittoolbar ul.tabs li.tab a:visited {
233 - float: left;
234 - padding-left: 18px;
235 - padding-right: 12px;
236 - display: block;
237 - height: 26px;
238 - cursor: pointer;
239 - color: #0645ad;
240 - background-image: url(images/arrow-right.png);
241 - background-position: left center;
242 - background-repeat: no-repeat;
243 -}
244 -body.rtl div#edittoolbar ul.tabs li.tab a,
245 -body.rtl div#edittoolbar ul.tabs li.tab a:visited {
246 - float: right;
247 - padding-left: 12px;
248 - padding-right: 18px;
249 - background-image: url(images/arrow-left.png);
250 - background-position: right center;
251 -}
252 -div#edittoolbar ul.tabs li.tab a.current,
253 -div#edittoolbar ul.tabs li.tab a.current:visited {
254 - color: #333333;
255 - background-image: url(images/arrow-down.png);
256 -}
257 -body.rtl div#edittoolbar ul.tabs li.tab a.current,
258 -body.rtl div#edittoolbar ul.tabs li.tab a.current:visited {
259 - background-image: url(images/arrow-down.png);
260 -}
261 -div#edittoolbar div.ul li.tab a.current:hover {
262 - text-decoration: none;
263270 }
\ No newline at end of file
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.hooks.php
@@ -53,51 +53,49 @@
5454 array(
5555 'edittoolbar-loading',
5656 /* Main Section */
57 - 'edittoolbar-tool-format-bold',
58 - 'edittoolbar-tool-format-bold-example',
59 - 'edittoolbar-tool-format-italic',
60 - 'edittoolbar-tool-format-italic-example',
61 - 'edittoolbar-tool-insert-ilink',
62 - 'edittoolbar-tool-insert-ilink-example',
63 - 'edittoolbar-tool-insert-xlink',
64 - 'edittoolbar-tool-insert-xlink-example',
65 - 'edittoolbar-tool-insert-file',
66 - 'edittoolbar-tool-insert-file-pre',
67 - 'edittoolbar-tool-insert-file-example',
68 - 'edittoolbar-tool-insert-reference',
69 - 'edittoolbar-tool-insert-reference-example',
70 - 'edittoolbar-tool-insert-signature',
 57+ 'edittoolbar-tool-bold',
 58+ 'edittoolbar-tool-bold-example',
 59+ 'edittoolbar-tool-italic',
 60+ 'edittoolbar-tool-italic-example',
 61+ 'edittoolbar-tool-ilink',
 62+ 'edittoolbar-tool-ilink-example',
 63+ 'edittoolbar-tool-xlink',
 64+ 'edittoolbar-tool-xlink-example',
 65+ 'edittoolbar-tool-file',
 66+ 'edittoolbar-tool-file-pre',
 67+ 'edittoolbar-tool-file-example',
 68+ 'edittoolbar-tool-reference',
 69+ 'edittoolbar-tool-reference-example',
 70+ 'edittoolbar-tool-signature',
7171 /* Formatting Section */
72 - 'edittoolbar-section-format',
73 - 'edittoolbar-tool-format-heading',
74 - 'edittoolbar-tool-format-heading-1',
75 - 'edittoolbar-tool-format-heading-2',
76 - 'edittoolbar-tool-format-heading-3',
77 - 'edittoolbar-tool-format-heading-4',
78 - 'edittoolbar-tool-format-heading-5',
79 - 'edittoolbar-tool-format-heading-example',
80 - 'edittoolbar-group-format-list',
81 - 'edittoolbar-tool-format-ulist',
82 - 'edittoolbar-tool-format-ulist-example',
83 - 'edittoolbar-tool-format-olist',
84 - 'edittoolbar-tool-format-olist-example',
85 - 'edittoolbar-group-format-size',
86 - 'edittoolbar-tool-format-big',
87 - 'edittoolbar-tool-format-big-example',
88 - 'edittoolbar-tool-format-small',
89 - 'edittoolbar-tool-format-small-example',
90 - 'edittoolbar-group-format-baseline',
91 - 'edittoolbar-tool-format-superscript',
92 - 'edittoolbar-tool-format-superscript-example',
93 - 'edittoolbar-tool-format-subscript',
94 - 'edittoolbar-tool-format-subscript-example',
95 - /* Insert Section */
96 - 'edittoolbar-section-insert',
97 - 'edittoolbar-group-insert-media',
98 - 'edittoolbar-tool-insert-gallery',
99 - 'edittoolbar-tool-insert-gallery-example',
100 - 'edittoolbar-group-insert-whitespace',
101 - 'edittoolbar-tool-insert-newline',
 72+ 'edittoolbar-section-advanced',
 73+ 'edittoolbar-tool-heading',
 74+ 'edittoolbar-tool-heading-1',
 75+ 'edittoolbar-tool-heading-2',
 76+ 'edittoolbar-tool-heading-3',
 77+ 'edittoolbar-tool-heading-4',
 78+ 'edittoolbar-tool-heading-5',
 79+ 'edittoolbar-tool-heading-example',
 80+ 'edittoolbar-group-list',
 81+ 'edittoolbar-tool-ulist',
 82+ 'edittoolbar-tool-ulist-example',
 83+ 'edittoolbar-tool-olist',
 84+ 'edittoolbar-tool-olist-example',
 85+ 'edittoolbar-group-size',
 86+ 'edittoolbar-tool-big',
 87+ 'edittoolbar-tool-big-example',
 88+ 'edittoolbar-tool-small',
 89+ 'edittoolbar-tool-small-example',
 90+ 'edittoolbar-group-baseline',
 91+ 'edittoolbar-tool-superscript',
 92+ 'edittoolbar-tool-superscript-example',
 93+ 'edittoolbar-tool-subscript',
 94+ 'edittoolbar-tool-subscript-example',
 95+ 'edittoolbar-group-media',
 96+ 'edittoolbar-tool-gallery',
 97+ 'edittoolbar-tool-gallery-example',
 98+ 'edittoolbar-group-whitespace',
 99+ 'edittoolbar-tool-newline',
102100 /* Special Characters Section */
103101 'edittoolbar-section-characters',
104102 /* Help Section */
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js
@@ -132,12 +132,17 @@
133133 if ( !( 'groups' in section ) ) {
134134 return;
135135 }
 136+ var first = true;
136137 // Loops over each group
137138 for ( group in section.groups ) {
138139 // Appends group
139140 var groupDiv = $( '<div />' )
140141 .attr( 'class', 'group' )
141142 .appendTo( $(this) );
 143+ if ( first ) {
 144+ groupDiv.addClass( 'first' );
 145+ first = false;
 146+ }
142147 // Checks if there's a label for this group
143148 if ( msgSet( section.groups[group], 'label' ) ) {
144149 groupDiv.append(
@@ -171,12 +176,13 @@
172177 case 'button':
173178 // Appends button
174179 groupDiv.append(
175 - $( '<img />' )
 180+ $( '<input />' )
176181 .attr( {
177182 src: imagePath + section.groups[group].tools[tool].icon,
178183 alt: label,
179184 title: label,
180 - 'class': 'tool'
 185+ 'class': 'tool',
 186+ 'type': 'image'
181187 } )
182188 .data( 'context', context )
183189 .click( action )
@@ -434,14 +440,14 @@
435441 'format': {
436442 tools: {
437443 'bold': {
438 - labelMsg: 'edittoolbar-tool-format-bold',
 444+ labelMsg: 'edittoolbar-tool-bold',
439445 type: 'button',
440446 icon: 'format-bold.png',
441447 action: {
442448 type: 'encapsulate',
443449 options: {
444450 pre: "'''",
445 - periMsg: 'edittoolbar-tool-format-bold-example',
 451+ periMsg: 'edittoolbar-tool-bold-example',
446452 post: "'''"
447453 }
448454 }
@@ -450,14 +456,14 @@
451457 section: 'main',
452458 group: 'format',
453459 id: 'italic',
454 - labelMsg: 'edittoolbar-tool-format-italic',
 460+ labelMsg: 'edittoolbar-tool-italic',
455461 type: 'button',
456462 icon: 'format-italic.png',
457463 action: {
458464 type: 'encapsulate',
459465 options: {
460466 pre: "''",
461 - periMsg: 'edittoolbar-tool-format-italic-example',
 467+ periMsg: 'edittoolbar-tool-italic-example',
462468 post: "''"
463469 }
464470 }
@@ -467,47 +473,47 @@
468474 'insert': {
469475 tools: {
470476 'xlink': {
471 - labelMsg: 'edittoolbar-tool-insert-xlink',
 477+ labelMsg: 'edittoolbar-tool-xlink',
472478 type: 'button',
473479 icon: 'insert-xlink.png',
474480 action: {
475481 type: 'encapsulate',
476482 options: {
477483 pre: "[",
478 - periMsg: 'edittoolbar-tool-insert-xlink-example',
 484+ periMsg: 'edittoolbar-tool-xlink-example',
479485 post: "]"
480486 }
481487 }
482488 },
483489 'ilink': {
484 - labelMsg: 'edittoolbar-tool-insert-ilink',
 490+ labelMsg: 'edittoolbar-tool-ilink',
485491 type: 'button',
486492 icon: 'insert-ilink.png',
487493 action: {
488494 type: 'encapsulate',
489495 options: {
490496 pre: "[[",
491 - periMsg: 'edittoolbar-tool-insert-ilink-example',
 497+ periMsg: 'edittoolbar-tool-ilink-example',
492498 post: "]]"
493499 }
494500 }
495501 },
496502 'file': {
497 - labelMsg: 'edittoolbar-tool-insert-file',
 503+ labelMsg: 'edittoolbar-tool-file',
498504 type: 'button',
499505 icon: 'insert-file.png',
500506 action: {
501507 type: 'encapsulate',
502508 options: {
503509 pre: "[[",
504 - preMsg: 'edittoolbar-tool-insert-file-pre',
505 - periMsg: 'edittoolbar-tool-insert-file-example',
 510+ preMsg: 'edittoolbar-tool-file-pre',
 511+ periMsg: 'edittoolbar-tool-file-example',
506512 post: "]]"
507513 }
508514 }
509515 },
510516 'reference': {
511 - labelMsg: 'edittoolbar-tool-insert-reference',
 517+ labelMsg: 'edittoolbar-tool-reference',
512518 filters: [ 'body.ns-subject' ],
513519 type: 'button',
514520 icon: 'insert-reference.png',
@@ -515,13 +521,13 @@
516522 type: 'encapsulate',
517523 options: {
518524 pre: "<ref>",
519 - periMsg: 'edittoolbar-tool-insert-reference-example',
 525+ periMsg: 'edittoolbar-tool-reference-example',
520526 post: "</ref>"
521527 }
522528 }
523529 },
524530 'signature': {
525 - labelMsg: 'edittoolbar-tool-insert-signature',
 531+ labelMsg: 'edittoolbar-tool-signature',
526532 filters: [ 'body.ns-talk' ],
527533 type: 'button',
528534 icon: 'insert-signature.png',
@@ -537,67 +543,67 @@
538544 }
539545 },
540546 // Format section
541 - 'format': {
542 - labelMsg: 'edittoolbar-section-format',
 547+ 'advanced': {
 548+ labelMsg: 'edittoolbar-section-advanced',
543549 type: 'toolbar',
544550 groups: {
545551 'heading': {
546552 tools: {
547553 'heading': {
548 - labelMsg: 'edittoolbar-tool-format-heading',
 554+ labelMsg: 'edittoolbar-tool-heading',
549555 type: 'select',
550556 list: {
551557 'heading-1' : {
552 - labelMsg: 'edittoolbar-tool-format-heading-1',
 558+ labelMsg: 'edittoolbar-tool-heading-1',
553559 action: {
554560 type: 'encapsulate',
555561 options: {
556562 pre: "=",
557 - periMsg: 'edittoolbar-tool-format-heading-example',
 563+ periMsg: 'edittoolbar-tool-heading-example',
558564 post: "="
559565 }
560566 }
561567 },
562568 'heading-2' : {
563 - labelMsg: 'edittoolbar-tool-format-heading-2',
 569+ labelMsg: 'edittoolbar-tool-heading-2',
564570 action: {
565571 type: 'encapsulate',
566572 options: {
567573 pre: "==",
568 - periMsg: 'edittoolbar-tool-format-heading-example',
 574+ periMsg: 'edittoolbar-tool-heading-example',
569575 post: "=="
570576 }
571577 }
572578 },
573579 'heading-3' : {
574 - labelMsg: 'edittoolbar-tool-format-heading-3',
 580+ labelMsg: 'edittoolbar-tool-heading-3',
575581 action: {
576582 type: 'encapsulate',
577583 options: {
578584 pre: "===",
579 - periMsg: 'edittoolbar-tool-format-heading-example',
 585+ periMsg: 'edittoolbar-tool-heading-example',
580586 post: "==="
581587 }
582588 }
583589 },
584590 'heading-4' : {
585 - labelMsg: 'edittoolbar-tool-format-heading-4',
 591+ labelMsg: 'edittoolbar-tool-heading-4',
586592 action: {
587593 type: 'encapsulate',
588594 options: {
589595 pre: "====",
590 - periMsg: 'edittoolbar-tool-format-heading-example',
 596+ periMsg: 'edittoolbar-tool-heading-example',
591597 post: "===="
592598 }
593599 }
594600 },
595601 'heading-5' : {
596 - labelMsg: 'edittoolbar-tool-format-heading-5',
 602+ labelMsg: 'edittoolbar-tool-heading-5',
597603 action: {
598604 type: 'encapsulate',
599605 options: {
600606 pre: "=====",
601 - periMsg: 'edittoolbar-tool-format-heading-example',
 607+ periMsg: 'edittoolbar-tool-heading-example',
602608 post: "====="
603609 }
604610 }
@@ -607,30 +613,30 @@
608614 }
609615 },
610616 'list': {
611 - labelMsg: 'edittoolbar-group-format-list',
 617+ labelMsg: 'edittoolbar-group-list',
612618 tools: {
613619 'ulist': {
614 - labelMsg: 'edittoolbar-tool-format-ulist',
 620+ labelMsg: 'edittoolbar-tool-ulist',
615621 type: 'button',
616622 icon: 'format-ulist.png',
617623 action: {
618624 type: 'encapsulate',
619625 options: {
620626 pre: "* ",
621 - periMsg: 'edittoolbar-tool-format-ulist-example',
 627+ periMsg: 'edittoolbar-tool-ulist-example',
622628 post: ""
623629 }
624630 }
625631 },
626632 'olist': {
627 - labelMsg: 'edittoolbar-tool-format-olist',
 633+ labelMsg: 'edittoolbar-tool-olist',
628634 type: 'button',
629635 icon: 'format-olist.png',
630636 action: {
631637 type: 'encapsulate',
632638 options: {
633639 pre: "# ",
634 - periMsg: 'edittoolbar-tool-format-olist-example',
 640+ periMsg: 'edittoolbar-tool-olist-example',
635641 post: ""
636642 }
637643 }
@@ -638,30 +644,30 @@
639645 }
640646 },
641647 'size': {
642 - labelMsg: 'edittoolbar-group-format-size',
 648+ labelMsg: 'edittoolbar-group-size',
643649 tools: {
644650 'big': {
645 - labelMsg: 'edittoolbar-tool-format-big',
 651+ labelMsg: 'edittoolbar-tool-big',
646652 type: 'button',
647653 icon: 'format-big.png',
648654 action: {
649655 type: 'encapsulate',
650656 options: {
651657 pre: "<big>",
652 - periMsg: 'edittoolbar-tool-format-big-example',
 658+ periMsg: 'edittoolbar-tool-big-example',
653659 post: "</big>"
654660 }
655661 }
656662 },
657663 'small': {
658 - labelMsg: 'edittoolbar-tool-format-small',
 664+ labelMsg: 'edittoolbar-tool-small',
659665 type: 'button',
660666 icon: 'format-small.png',
661667 action: {
662668 type: 'encapsulate',
663669 options: {
664670 pre: "<small>",
665 - periMsg: 'edittoolbar-tool-format-small-example',
 671+ periMsg: 'edittoolbar-tool-small-example',
666672 post: "</small>"
667673 }
668674 }
@@ -669,69 +675,48 @@
670676 }
671677 },
672678 'baseline': {
673 - labelMsg: 'edittoolbar-group-format-baseline',
 679+ labelMsg: 'edittoolbar-group-baseline',
674680 tools: {
675681 'superscript': {
676 - labelMsg: 'edittoolbar-tool-format-superscript',
 682+ labelMsg: 'edittoolbar-tool-superscript',
677683 type: 'button',
678684 icon: 'format-superscript.png',
679685 action: {
680686 type: 'encapsulate',
681687 options: {
682688 pre: "<sup>",
683 - periMsg: 'edittoolbar-tool-format-superscript-example',
 689+ periMsg: 'edittoolbar-tool-superscript-example',
684690 post: "</sup>"
685691 }
686692 }
687693 },
688694 'subscript': {
689 - labelMsg: 'edittoolbar-tool-format-subscript',
 695+ labelMsg: 'edittoolbar-tool-subscript',
690696 type: 'button',
691697 icon: 'format-subscript.png',
692698 action: {
693699 type: 'encapsulate',
694700 options: {
695701 pre: "<sub>",
696 - periMsg: 'edittoolbar-tool-format-subscript-example',
 702+ periMsg: 'edittoolbar-tool-subscript-example',
697703 post: "</sub>"
698704 }
699705 }
700706 }
701707 }
702 - }
703 - }
704 - },
705 - // Insert section
706 - 'insert': {
707 - labelMsg: 'edittoolbar-section-insert',
708 - type: 'toolbar',
709 - groups: {
 708+ },
710709 'media': {
711 - labelMsg: 'edittoolbar-group-insert-media',
 710+ labelMsg: 'edittoolbar-group-media',
712711 tools: {
713 - 'file': {
714 - labelMsg: 'edittoolbar-tool-insert-file',
715 - type: 'button',
716 - icon: 'insert-file.png',
717 - action: {
718 - type: 'encapsulate',
719 - options: {
720 - pre: "[[",
721 - preMsg: 'edittoolbar-tool-insert-file-pre',
722 - periMsg: 'edittoolbar-tool-insert-file-example',
723 - post: "]]"
724 - }
725 - }
726 - },
727712 'gallery': {
728 - labelMsg: 'edittoolbar-tool-insert-gallery',
 713+ labelMsg: 'edittoolbar-tool-gallery',
729714 type: 'button',
730715 icon: 'insert-gallery.png',
731716 action: {
732717 type: 'encapsulate',
733718 options: {
734719 pre: "<gallery>\n",
735 - periMsg: 'edittoolbar-tool-insert-gallery-example',
 720+ periMsg: 'edittoolbar-tool-gallery-example',
736721 post: "\n</gallery>"
737722 }
738723 }
@@ -739,10 +724,10 @@
740725 }
741726 },
742727 'whitespace': {
743 - labelMsg: 'edittoolbar-group-insert-whitespace',
 728+ labelMsg: 'edittoolbar-group-whitespace',
744729 tools: {
745730 'newline': {
746 - labelMsg: 'edittoolbar-tool-insert-newline',
 731+ labelMsg: 'edittoolbar-tool-newline',
747732 type: 'button',
748733 icon: 'insert-newline.png',
749734 action: {

Status & tagging log