r52406 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52405‎ | r52406 | r52407 >
Date:19:04, 25 June 2009
Author:raymond
Status:ok
Tags:
Comment:
Follow-up r52401:
* Fix typo in PLURA and let PLURAL work
* Localize the number
Modified paths:
  • /trunk/extensions/ConfirmAccount/ConfirmAccount.i18n.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/RequestAccount_body.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/SpecialConfirmAccount.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/SpecialConfirmAccount.php
@@ -13,7 +13,7 @@
1414 'descriptionmsg' => 'confirmedit-desc',
1515 'author' => 'Aaron Schulz',
1616 'url' => 'http://www.mediawiki.org/wiki/Extension:ConfirmAccount',
17 - 'version' => '1.47',
 17+ 'version' => '1.48',
1818 );
1919
2020 # This extension needs email enabled!
Index: trunk/extensions/ConfirmAccount/RequestAccount_body.php
@@ -285,7 +285,8 @@
286286 global $wgAccountRequestMinWords;
287287 # Check if biography is long enough
288288 if ( str_word_count( $this->mBio ) < $wgAccountRequestMinWords ) {
289 - $this->showForm( wfMsgHtml( 'requestaccount-tooshort', $wgAccountRequestMinWords ) );
 289+ global $wgLang;
 290+ $this->showForm( wfMsgExt( 'requestaccount-tooshort', 'parsemag', $wgLang->formatNum( $wgAccountRequestMinWords ) ) );
290291 return;
291292 }
292293 # Set some additional data so the AbortNewAccount hook can be
Index: trunk/extensions/ConfirmAccount/ConfirmAccount.i18n.php
@@ -46,7 +46,7 @@
4747 'requestaccount-urls' => 'List of websites, if any (separate with newlines):',
4848 'requestaccount-agree' => 'You must certify that your real name is correct and that you agree to our Terms of Service.',
4949 'requestaccount-inuse' => 'Username is already in use in a pending account request.',
50 - 'requestaccount-tooshort' => 'Your biography must be at least be $1 {{PLURA:$1|word|words}} long.',
 50+ 'requestaccount-tooshort' => 'Your biography must be at least be $1 {{PLURAL:$1|word|words}} long.',
5151 'requestaccount-emaildup' => 'Another pending account request uses the same e-mail address.',
5252 'requestaccount-exts' => 'Attachment file type is disallowed.',
5353 'requestaccount-resub' => 'Your CV/resume file must be re-selected for security reasons.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52401PLURAL added to message accoring to request of EugeneZelenko at...purodha16:33, 25 June 2009

Status & tagging log