r52296 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52295‎ | r52296 | r52297 >
Date:19:38, 22 June 2009
Author:catrope
Status:deferred
Tags:
Comment:
NavigableTOC: Change some uses of $() to jQuery() to shut up error about $ not being a function on the prototype sandbox
Modified paths:
  • /trunk/extensions/UsabilityInitiative/NavigableTOC/NavigableTOC.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/NavigableTOC/NavigableTOC.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/NavigableTOC/NavigableTOC.php
@@ -18,7 +18,7 @@
1919 /* Configuration */
2020
2121 // Bump the version number every time you change any of the .css/.js files
22 -$wgNavigableTOCStyleVersion = 0;
 22+$wgNavigableTOCStyleVersion = 1;
2323
2424 /* Setup */
2525
Index: trunk/extensions/UsabilityInitiative/NavigableTOC/NavigableTOC.js
@@ -140,8 +140,8 @@
141141 });
142142 }
143143 $( '.toc:last * li a' ).click( function(e) {
144 - if( typeof $(this).data( 'offset' ) != 'undefined' )
145 - $( '#wpTextbox1' ).scrollToPosition( $(this).data( 'offset' ) );
 144+ if( typeof jQuery(this).data( 'offset' ) != 'undefined' )
 145+ jQuery( '#wpTextbox1' ).scrollToPosition( jQuery(this).data( 'offset' ) );
146146 e.preventDefault();
147147 });
148148

Status & tagging log