r52074 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52073‎ | r52074 | r52075 >
Date:21:03, 17 June 2009
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Cast quality value as integer for clarity
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -941,7 +941,7 @@
942942 */
943943 public static function getRevQuality( $page_id, $rev_id, $flags=0 ) {
944944 $db = ($flags & GAID_FOR_UPDATE) ? wfGetDB( DB_MASTER ) : wfGetDB( DB_SLAVE );
945 - return $db->selectField( 'flaggedrevs',
 945+ return (int)$db->selectField( 'flaggedrevs',
946946 'fr_quality',
947947 array( 'fr_page_id' => $page_id, 'fr_rev_id' => $rev_id ),
948948 __METHOD__,

Comments

#Comment by Aaron Schulz (talk | contribs)   07:59, 18 June 2009

broken, reverted in r52091

Status & tagging log