r51910 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r51909
|
r51910
|
r51911
>
Date:
15:17, 15 June 2009
Author:
nikerabbit
Status:
ok (
Comments
)
Tags:
Comment:
Regression in
r51797
, anon signature links where prefixed with contributions/ because default value changed from '' to null
Modified paths:
/trunk/phase3/includes/parser/Parser.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/includes/parser/Parser.php
—
—
@@ -3812,7 +3812,7 @@
3813
3813
3814
3814
$username = $user->getName();
3815
3815
$nickname = $user->getOption( 'nickname' );
3816
- $nickname = $nickname === '' ? $username : $nickname;
3816
+ $nickname = $nickname === null ? $username : $nickname;
3817
3817
3818
3818
if( mb_strlen( $nickname ) > $wgMaxSigChars ) {
3819
3819
$nickname = $username;
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r51797
* Tweak getOption() to set the value in $mOptions so we don't have to re-prov...
demon
19:05, 12 June 2009
Comments
#
Comment by
Nikerabbit
(
talk
|
contribs
)
15:34, 15 June 2009
Culprit is not
r51797
, sorry. No idea what is then.
Status & tagging log
23:55, 15 June 2009
Tim Starling
(
talk
|
contribs
)
changed the
status
of r51910
[
removed:
new
added:
ok]